New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the storage version hash to the discovery API #73191

Merged
merged 2 commits into from Jan 29, 2019

Conversation

@caesarxuchao
Copy link
Member

caesarxuchao commented Jan 23, 2019

Extracted the API changes from #72942.

Implementing https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/35-storage-version-hash.md.

/sig api-machinery
/assign @caesarxuchao
Keeping to myself until tests pass.
/kind feature

Added alpha field storageVersionHash to the discovery document for each resource. Its value must be treated as opaque by clients. Only equality comparison on the value is valid.
@caesarxuchao

This comment has been minimized.

Copy link
Member Author

caesarxuchao commented Jan 23, 2019

/retest
/unassign
/assign @deads2k @liggitt @yliaog

@yliaog

This comment has been minimized.

Copy link
Contributor

yliaog commented Jan 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 23, 2019

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

caesarxuchao commented Jan 24, 2019

@liggitt this one needs a API approval. PTAL. Thanks.

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jan 28, 2019

@liggitt ptal.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 28, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

caesarxuchao added some commits Jan 15, 2019

generated BUILD
generated proto

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:expose-storage-version-hash-api branch from d9aa998 to 3419ade Jan 28, 2019

@yliaog

This comment has been minimized.

Copy link
Contributor

yliaog commented Jan 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 28, 2019

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

caesarxuchao commented Jan 28, 2019

/retest

2 similar comments
@caesarxuchao

This comment has been minimized.

Copy link
Member Author

caesarxuchao commented Jan 29, 2019

/retest

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

caesarxuchao commented Jan 29, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 29, 2019

@caesarxuchao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 3419ade link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 81af418 into kubernetes:master Jan 29, 2019

17 of 18 checks passed

pull-kubernetes-e2e-kops-aws Job failed.
Details
cla/linuxfoundation caesarxuchao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment