fix shellcheck in code-generator #73246
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ set -o pipefail | |
|
|
||
| if [ "$#" -lt 5 ] || [ "${1}" == "--help" ]; then | ||
| cat <<EOF | ||
| Usage: $(basename "$0") <generators> <output-package> <internal-apis-package> <extensiona-apis-package> <groups-versions> ... | ||
|
|
||
| <generators> the generators comma separated to run (deepcopy,defaulter,conversion,client,lister,informer) or "all". | ||
| <output-package> the output package name (e.g. github.com/example/project/pkg/generated). | ||
|
|
@@ -34,8 +34,8 @@ Usage: $(basename $0) <generators> <output-package> <internal-apis-package> <ext | |
| ... arbitrary flags passed to all generator binaries. | ||
|
|
||
| Examples: | ||
| $(basename "$0") all github.com/example/project/pkg/client github.com/example/project/pkg/apis github.com/example/project/pkg/apis "foo:v1 bar:v1alpha1,v1beta1" | ||
| $(basename "$0") deepcopy,defaulter,conversion github.com/example/project/pkg/client github.com/example/project/pkg/apis github.com/example/project/apis "foo:v1 bar:v1alpha1,v1beta1" | ||
| EOF | ||
| exit 0 | ||
| fi | ||
|
|
@@ -47,15 +47,15 @@ EXT_APIS_PKG="$4" | |
| GROUPS_WITH_VERSIONS="$5" | ||
| shift 5 | ||
|
|
||
|
There was a problem hiding this comment. ref: #73246 (comment) , so we think it maybe the best answer to pass shellcheck here. |
||
| go install ./"$(dirname "${0}")"/cmd/{defaulter-gen,conversion-gen,client-gen,lister-gen,informer-gen,deepcopy-gen} | ||
| function codegen::join() { local IFS="$1"; shift; echo "$*"; } | ||
|
|
||
| # enumerate group versions | ||
| ALL_FQ_APIS=() # e.g. k8s.io/kubernetes/pkg/apis/apps k8s.io/api/apps/v1 | ||
| INT_FQ_APIS=() # e.g. k8s.io/kubernetes/pkg/apis/apps | ||
| EXT_FQ_APIS=() # e.g. k8s.io/api/apps/v1 | ||
| for GVs in ${GROUPS_WITH_VERSIONS}; do | ||
| IFS=: read -r G Vs <<<"${GVs}" | ||
|
|
||
| if [ -n "${INT_APIS_PKG}" ]; then | ||
| ALL_FQ_APIS+=("${INT_APIS_PKG}/${G}") | ||
|
|
@@ -71,39 +71,40 @@ done | |
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "deepcopy" <<<"${GENS}"; then | ||
| echo "Generating deepcopy funcs" | ||
| "${GOPATH}/bin/deepcopy-gen" --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" -O zz_generated.deepcopy --bounding-dirs "${INT_APIS_PKG},${EXT_APIS_PKG}" "$@" | ||
| fi | ||
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "defaulter" <<<"${GENS}"; then | ||
| echo "Generating defaulters" | ||
| "${GOPATH}/bin/defaulter-gen" --input-dirs "$(codegen::join , "${EXT_FQ_APIS[@]}")" -O zz_generated.defaults "$@" | ||
| fi | ||
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "conversion" <<<"${GENS}"; then | ||
| echo "Generating conversions" | ||
| "${GOPATH}/bin/conversion-gen" --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" -O zz_generated.conversion "$@" | ||
| fi | ||
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "client" <<<"${GENS}"; then | ||
| echo "Generating clientset for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}" | ||
| if [ -n "${INT_APIS_PKG}" ]; then | ||
| IFS=" " read -r -a APIS <<< "$(printf '%s/ ' "${INT_FQ_APIS[@]}")" | ||
|
There was a problem hiding this comment. what does this do? This need a comment, if at all necessary. There was a problem hiding this comment. ref: #73246 (comment) . |
||
| "${GOPATH}/bin/client-gen" --clientset-name "${CLIENTSET_NAME_INTERNAL:-internalversion}" --input-base "" --input "$(codegen::join , "${APIS[@]}")" --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}" "$@" | ||
| fi | ||
| "${GOPATH}/bin/client-gen" --clientset-name "${CLIENTSET_NAME_VERSIONED:-versioned}" --input-base "" --input "$(codegen::join , "${EXT_FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}" "$@" | ||
| fi | ||
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "lister" <<<"${GENS}"; then | ||
| echo "Generating listers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/listers" | ||
| "${GOPATH}/bin/lister-gen" --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/listers" "$@" | ||
| fi | ||
|
|
||
| if [ "${GENS}" = "all" ] || grep -qw "informer" <<<"${GENS}"; then | ||
| echo "Generating informers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/informers" | ||
| "${GOPATH}/bin/informer-gen" \ | ||
| --input-dirs "$(codegen::join , "${ALL_FQ_APIS[@]}")" \ | ||
| --versioned-clientset-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}/${CLIENTSET_NAME_VERSIONED:-versioned}" \ | ||
| --internal-clientset-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}/${CLIENTSET_NAME_INTERNAL:-internalversion}" \ | ||
| --listers-package "${OUTPUT_PKG}/listers" \ | ||
| --output-package "${OUTPUT_PKG}/informers" \ | ||
| "$@" | ||
| fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it hits https://github.com/koalaman/shellcheck/wiki/SC2162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks good