Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go1.10.8 #73329

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Update to go1.10.8 #73329

merged 1 commit into from
Jan 26, 2019

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jan 25, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it: updates to use go1.10.8, which fixes CVE-2019-6486.

Which issue(s) this PR fixes:
x-ref #73238

Does this PR introduce a user-facing change?:

Update to go1.10.8

/assign @BenTheElder @cblecker @feiskyer
/sig release
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 25, 2019
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 25, 2019
@k8s-ci-robot
Copy link
Contributor

@ixdy: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 25, 2019
@cblecker
Copy link
Member

/lgtm
/approve
/hold

@BenTheElder
Copy link
Member

/retest

@ixdy
Copy link
Member Author

ixdy commented Jan 25, 2019

/area security
/hold cancel

@ixdy
Copy link
Member Author

ixdy commented Jan 25, 2019

/retest

3 similar comments
@cblecker
Copy link
Member

/retest

@ixdy
Copy link
Member Author

ixdy commented Jan 26, 2019

/retest

@ixdy
Copy link
Member Author

ixdy commented Jan 26, 2019

/retest

@cblecker
Copy link
Member

/test pull-kubernetes-integration
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2019
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 973dcd0 into kubernetes:release-1.12 Jan 26, 2019
@nikhita nikhita mentioned this pull request Jan 26, 2019
Merged
This was referenced Jan 27, 2019
Closed
Closed
@tabern tabern mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@feiskyer feiskyer

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ixdy @k8s-ci-robot @cblecker @BenTheElder @feiskyer