Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpuPeriod was not reset #73342

Merged
merged 1 commit into from Feb 12, 2019
Merged

cpuPeriod was not reset #73342

merged 1 commit into from Feb 12, 2019

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Jan 26, 2019 •
edited 

fix #73264 cpuPeriod was not reset, but used as set via flag, although it was disabled via alpha gate

Signed-off-by: Sandor Szücs sandor.szuecs@zalando.de

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @szuecs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2019
@szuecs szuecs mentioned this pull request Jan 26, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

@szuecs: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zouyee
Copy link
Member

zouyee commented Jan 29, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2019
@szuecs szuecs force-pushed the fix/period-not-reset-if-gate-not-set branch 2 times, most recently from 4c9ce48 to 00bac0d Compare February 1, 2019 15:42
@szuecs
fix kubernetes#73264 cpuPeriod was not reset, but used as it is if al…
fd0cff9 
…pha gate is disabled

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs szuecs force-pushed the fix/period-not-reset-if-gate-not-set branch from 00bac0d to fd0cff9 Compare February 1, 2019 15:45
@dashpole
Copy link
Contributor

dashpole commented Feb 1, 2019

Looks much better!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2019
@szuecs
Copy link
Member Author

szuecs commented Feb 3, 2019

/test pull-kubernetes-local-e2e-containerized

@szuecs
Copy link
Member Author

szuecs commented Feb 3, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@szuecs
Copy link
Member Author

szuecs commented Feb 3, 2019

/test pull-kubernetes-local-e2e-containerized

@szuecs
Copy link
Member Author

szuecs commented Feb 3, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 3, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 3, 2019
@szuecs
Copy link
Member Author

szuecs commented Feb 3, 2019

@dchen1107 or @dims could you review this fix please?
Thanks!

@szuecs
Copy link
Member Author

szuecs commented Feb 7, 2019

/test pull-kubernetes-local-e2e-containerized

@szuecs
Copy link
Member Author

szuecs commented Feb 7, 2019

@yujuhong or @Random-Liu could you review this PR please, thanks!

@k8s-ci-robot
Copy link
Contributor

@szuecs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 5fb69bd85b915f77468e23e1773cfb03a5d64fb9 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-local-e2e-containerized fd0cff9 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yujuhong
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c9964aa into kubernetes:master Feb 12, 2019
@szuecs szuecs mentioned this pull request May 26, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@szuecs @k8s-ci-robot @zouyee @dashpole @yujuhong @fejta-bot