Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten health check timeout for AWS NLB with externalTrafficPolicy: Local #73363

Merged

Conversation

@kellycampbell
Copy link
Contributor

kellycampbell commented Jan 27, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Shorten AWS NLB health check time when externalTrafficPolicy is Local to minimum

Which issue(s) this PR fixes:
Fixes #73362

Minimize AWS NLB health check timeout when externalTrafficPolicy set to Local
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 27, 2019

Hi @kellycampbell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from bb0b78c to 05cf67c Jan 27, 2019
@k8s-ci-robot k8s-ci-robot requested review from chrislovecnm and jsafrane Jan 27, 2019
Copy link
Member

neolit123 left a comment

/priority important-longterm
/ok-to-test
/sig aws

@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Jan 27, 2019

/test pull-kubernetes-integration

@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Jan 29, 2019

@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Mar 11, 2019

Any feedback or anything on this? @M00nF1sh @d-nishi @chrislovecnm

@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from 05cf67c to a6d309b Apr 17, 2019
@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from a6d309b to 30af8e3 Apr 17, 2019
@kellycampbell kellycampbell changed the title Use more aggressive health check for NLB with externalTrafficPolicy: Local Shorten health check timeout for AWS NLB with externalTrafficPolicy: Local Apr 17, 2019
@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Apr 17, 2019

/assign @micahhausler

@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Apr 18, 2019

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Apr 25, 2019

/cc @justinsb

@micahhausler

This comment has been minimized.

Copy link
Member

micahhausler commented Jul 29, 2019

/remove-lifecycle stale
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm and removed lifecycle/stale labels Jul 29, 2019
@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Jul 29, 2019

/approve

@micahhausler

This comment has been minimized.

Copy link
Member

micahhausler commented Jul 29, 2019

This diff needs to be rebased and move to the new location in /staging/src/k8s.io/legacy-cloud-providers/aws

@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from 30af8e3 to 6ddf287 Jul 29, 2019
@kellycampbell

This comment has been minimized.

Copy link
Contributor Author

kellycampbell commented Jul 29, 2019

@micahhausler thanks. I've rebased.

Copy link
Member

micahhausler left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 30, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, kellycampbell, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from 6ddf287 to 7b00819 Jul 31, 2019
@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from 7b00819 to 45e744c Aug 30, 2019
…Local

This is a fix for issue #73362
@kellycampbell kellycampbell force-pushed the kellycampbell:nlb-local-healthchecks branch from 45e744c to 0b481e8 Sep 27, 2019
@kellycampbell kellycampbell requested a review from micahhausler Oct 4, 2019
@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 14, 2019

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 8, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 67647ed into kubernetes:master Jan 8, 2020
16 checks passed
16 checks passed
cla/linuxfoundation kellycampbell authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.