Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten health check timeout for AWS NLB with externalTrafficPolicy: Local #73363

Merged
merged 1 commit into from Jan 8, 2020
Merged

Shorten health check timeout for AWS NLB with externalTrafficPolicy: Local #73363

merged 1 commit into from Jan 8, 2020

Conversation

kellycampbell
Copy link

@kellycampbell kellycampbell commented Jan 27, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Shorten AWS NLB health check time when externalTrafficPolicy is Local to minimum

Which issue(s) this PR fixes:
Fixes #73362

Minimize AWS NLB health check timeout when externalTrafficPolicy set to Local

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kellycampbell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 27, 2019
neolit123
neolit123 reviewed Jan 27, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-longterm
/ok-to-test
/sig aws

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/aws and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 27, 2019
@kellycampbell
Copy link
Author

/test pull-kubernetes-integration

@kellycampbell
Copy link
Author

kubernetes/enhancements#423

@kellycampbell
Copy link
Author

Any feedback or anything on this? @M00nF1sh @d-nishi @chrislovecnm

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2019
@kellycampbell kellycampbell changed the title Use more aggressive health check for NLB with externalTrafficPolicy: Local Shorten health check timeout for AWS NLB with externalTrafficPolicy: Local Apr 17, 2019
@kellycampbell
Copy link
Author

/assign @micahhausler

@kellycampbell
Copy link
Author

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@kellycampbell
Copy link
Author

/cc @justinsb

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2019
@micahhausler
Copy link
Member

/remove-lifecycle stale
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 29, 2019
@jsafrane
Copy link
Member

/approve

@micahhausler
Copy link
Member

This diff needs to be rebased and move to the new location in /staging/src/k8s.io/legacy-cloud-providers/aws

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 29, 2019
@kellycampbell
Copy link
Author

@micahhausler thanks. I've rebased.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
micahhausler
micahhausler approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, kellycampbell, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. sig/aws labels Jul 31, 2019
@dims
Copy link
Member

dims commented Nov 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 67647ed into kubernetes:master Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@jsafrane jsafrane Awaiting requested review from jsafrane

@justinsb justinsb Awaiting requested review from justinsb

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@dims dims

@micahhausler micahhausler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

AWS NLB with externalTrafficPolicy: Local: Health check defaults take 90s to remove node
7 participants
@kellycampbell @k8s-ci-robot @fejta-bot @micahhausler @jsafrane @dims @neolit123