Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime_handler into PodSandbox and PodSandboxStatus #73833

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Add runtime_handler into PodSandbox and PodSandboxStatus #73833

merged 1 commit into from
Feb 16, 2019

Conversation

haiyanmeng
Copy link
Contributor

@haiyanmeng haiyanmeng commented Feb 7, 2019 •
edited
Loading

What type of PR is this?
/kind api-change

What this PR does / why we need it:
See #73707

Which issue(s) this PR fixes:
Fixes #73707

[CRI] Add a new field called `runtime_handler` into PodSandbox and PodSandboxStatus to track the RuntimeClass information of a pod.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @haiyanmeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haiyanmeng
Copy link
Contributor Author

/sig node
/cc @Random-Liu

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2019
@Random-Liu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2019
@haiyanmeng
Copy link
Contributor Author

/test pull-kubernetes-verify
/test pull-kubernetes-local-e2e-containerized

@haiyanmeng
Copy link
Contributor Author

/test pull-kubernetes-verify

@haiyanmeng
Copy link
Contributor Author

/cc @timstclair
/assign @Random-Liu

@tallclair
Copy link
Member

/cc @mrunalp

@tallclair
Copy link
Member

/cc @yujuhong

@tallclair
Copy link
Member

lgtm, but I'll let others review.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 12, 2019
@yujuhong
Copy link
Contributor

/lgtm
/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haiyanmeng, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 063e7ff into kubernetes:master Feb 16, 2019
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
8926e09 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
a9eafac 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
6dd006b 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
a7b72ca 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
f69f35b 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
@haiyanmeng haiyanmeng mentioned this pull request Feb 27, 2019
Merged
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
26a3637 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
333541d 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
@haiyanmeng haiyanmeng mentioned this pull request Feb 27, 2019
Closed
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
a915ab1 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri-o that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
e7a85ad 
The upstream CRI change: [kubernetes/kubernetes#73833](kubernetes/kubernetes#73833)

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
a673148 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
6a7ee9e 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
4651a5f 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
bf7e9e4 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
ca40633 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
bddbf4c 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
d30e708 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019
@haiyanmeng
Add RuntimeHandler into PodSandbox and PodSandboxStatus
9dea9d3 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
kevpar pushed a commit to kevpar/cri that referenced this pull request Sep 1, 2020
@haiyanmeng @kevpar
Add RuntimeHandler into PodSandbox and PodSandboxStatus
c3d8617 
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
(cherry picked from commit 9dea9d3)
Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
@kevpar kevpar mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmorie pmorie Awaiting requested review from pmorie

@sjenning sjenning Awaiting requested review from sjenning

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@timstclair timstclair Awaiting requested review from timstclair

@mrunalp mrunalp Awaiting requested review from mrunalp

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@mrunalp mrunalp

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include RuntimeClass information in ListPodSandboxResponse and PodSandboxStatusResponse
6 participants
@haiyanmeng @k8s-ci-robot @Random-Liu @tallclair @mrunalp @yujuhong