Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `runtime_handler` into PodSandbox and PodSandboxStatus #73833

Merged
merged 1 commit into from Feb 16, 2019

Conversation

@haiyanmeng
Copy link
Contributor

haiyanmeng commented Feb 7, 2019

What type of PR is this?
/kind api-change

What this PR does / why we need it:
See #73707

Which issue(s) this PR fixes:
Fixes #73707

[CRI] Add a new field called `runtime_handler` into PodSandbox and PodSandboxStatus to track the RuntimeClass information of a pod.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 7, 2019

Hi @haiyanmeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

haiyanmeng commented Feb 7, 2019

/sig node
/cc @Random-Liu

@Random-Liu

This comment has been minimized.

Copy link
Member

Random-Liu commented Feb 7, 2019

/ok-to-test

@haiyanmeng haiyanmeng force-pushed the haiyanmeng:cri_runtimeclass branch from cf86e6c to c353358 Feb 7, 2019

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

haiyanmeng commented Feb 7, 2019

/test pull-kubernetes-verify
/test pull-kubernetes-local-e2e-containerized

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

haiyanmeng commented Feb 8, 2019

/test pull-kubernetes-verify

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

haiyanmeng commented Feb 8, 2019

/cc @timstclair
/assign @Random-Liu

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Feb 8, 2019

/cc @mrunalp

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp Feb 8, 2019

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Feb 8, 2019

/cc @yujuhong

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong Feb 8, 2019

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Feb 8, 2019

lgtm, but I'll let others review.

@mrunalp

This comment has been minimized.

Copy link
Contributor

mrunalp commented Feb 9, 2019

/lgtm

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Feb 12, 2019

Please add a release note

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Feb 15, 2019

/lgtm
/approve
/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haiyanmeng, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 063e7ff into kubernetes:master Feb 16, 2019

17 checks passed

cla/linuxfoundation haiyanmeng authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri-o that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: [kubernetes/kubernetes#73833](kubernetes/kubernetes#73833)

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 27, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

haiyanmeng added a commit to haiyanmeng/cri that referenced this pull request Feb 28, 2019

Add RuntimeHandler into PodSandbox and PodSandboxStatus
The upstream CRI change: kubernetes/kubernetes#73833

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.