kubeadm: Don't dump backtrace on reset #73951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code logs an error and full blown backtrace if we fail to remove the containers upon reset. This creates unneeded, huge and rather scary log message. Fix that by leaving just the error message. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-priority
|
@fabriziopandini @timothysc I wonder if this is worthy of cherry-picking in 1.12 and 1.13? |
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
added
the
approved
|
@rosti thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123, rosti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The current code logs an error and full blown backtrace if we fail to remove
the containers upon reset. This creates unneeded, huge and rather scary log
message. Fix that by leaving just the error message.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1404
Special notes for your reviewer:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/assign @neolit123
/cc @chuckha
Does this PR introduce a user-facing change?: