add ResourceVersion to DeleteOptions.Preconditions #74040
What type of PR is this?
What this PR does / why we need it:
Does this PR introduce a user-facing change?:
Hi @ajatprabha. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Feb 13, 2019
lavalamp left a comment
This looks basically ready to go, thanks for the change! After API reviewer sign off (I would do it here but there's a new process) this should merge and then I think the last thing to do is a documentation update.
I meant to lgtm/approve this right after last API Machinery SIG meeting and (clearly) it didn't happen. Now it is code freeze so we need some sort of exception I'm sure :(
My schedule today is... full, so I'm not going to have a chance to look up the process. @ajatprabha if you have time to do that, I'm happy to sponsor or vouch for the change if that's a part of the process.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing