add ResourceVersion to DeleteOptions.Preconditions

[ajatprabha]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This PR adds ResourceVersion as a precondition for delete in order to ensure a delete fails if an unobserved change happens to an object.
Which issue(s) this PR fixes:

Fixes #73648

Does this PR introduce a user-facing change?:

Add ResourceVersion as a precondition for delete in order to ensure a delete fails if an unobserved change happens to an object.

[k8s-ci-robot]

Hi @ajatprabha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ajatprabha]

/assign @lavalamp

[lavalamp]

/ok-to-test

/assign @jennybuckley

[jennybuckley]

This probably needs a release note since it changes the API
@kubernetes/api-reviewers

[ajatprabha]

I need help with failing Integration tests at etcd_storage_path_test.go:121. I tried a few ways to fix with no luck.
https://github.com/kubernetes/kubernetes/blob/6e5f69f25c8196b91cb2f80add163832624a86ef/test/integration/etcd/etcd_storage_path_test.go#L118-L124 https://github.com/kubernetes/kubernetes/blob/6e5f69f25c8196b91cb2f80add163832624a86ef/test/integration/etcd/etcd_storage_path_test.go#L296-L306 cc: @liggitt @lavalamp @jennybuckley

[fejta-bot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[lavalamp]

This looks basically ready to go, thanks for the change! After API reviewer sign off (I would do it here but there's a new process) this should merge and then I think the last thing to do is a documentation update.

[lavalamp]

I meant to lgtm/approve this right after last API Machinery SIG meeting and (clearly) it didn't happen. Now it is code freeze so we need some sort of exception I'm sure :(

My schedule today is... full, so I'm not going to have a chance to look up the process. @ajatprabha if you have time to do that, I'm happy to sponsor or vouch for the change if that's a part of the process.

[ajatprabha]

/test pull-kubernetes-godeps

[ajatprabha]

/test pull-kubernetes-e2e-gce

[nikopen]

/milestone v1.14

[lavalamp]

/approve
/lgtm

Thanks for the change!

[lavalamp]

(Just FYI, I would ask for a squash but I don't want to risk another rebase...)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajatprabha, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [lavalamp]
• pkg/registry/OWNERS [lavalamp]
• staging/src/k8s.io/apiextensions-apiserver/OWNERS [lavalamp]
• staging/src/k8s.io/apimachinery/pkg/apis/OWNERS [lavalamp]
• staging/src/k8s.io/apiserver/OWNERS [lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment