Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE config.sh script should use headers for curl GCS apis #74142

Merged
merged 1 commit into from Feb 21, 2019
Merged

GCE config.sh script should use headers for curl GCS apis #74142

merged 1 commit into from Feb 21, 2019

Conversation

javier-b-perez
Copy link
Contributor

@javier-b-perez javier-b-perez commented Feb 15, 2019 •
edited

Modify GCE config.sh script to get metadata and Service Account token for the running instance.
Use token to retrieve objects in GCS buckets.
When the SA doesn't have 'Storage Read' scope, it can only read from public GCS buckets.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Allow GCE VMs to retrieve artifacts from private GCS buckets during configuration.
If we don't use the token in the headers, it can only read public objects in GCS.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

NONE

k8s: gci: configure: add token to curl calls
708d7df 
Modify script to use curl to get metadata and Service Account token.
When the SA doesn't have 'Storage Read' scope, it can only read
public files.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @javier-b-perez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2019
@javier-b-perez
Copy link
Contributor Author

/assign yguo0905
/assign dchen1107

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2019
@yguo0905
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2019
@javier-b-perez
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@yguo0905
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javier-b-perez, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2019
@zmerlynn
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 054a676 into kubernetes:master Feb 21, 2019
mtaufen added a commit to mtaufen/kubernetes that referenced this pull request May 30, 2019
@mtaufen
Windows startup scripts should use Authorization header for GCS requests
e2116ef 
Requests against private buckets will fail unless the VM has storage
scope and the default service account token is provided in the request
header.

This PR replicates the following Linux changes for Windows:
- kubernetes#74142
- kubernetes#75269
@mtaufen mtaufen mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@zmerlynn zmerlynn

@dchen1107 dchen1107

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@javier-b-perez @k8s-ci-robot @yguo0905 @zmerlynn @dchen1107