-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Support >= 5.0 Linux kernel #74355
Conversation
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Hi @brb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a valid change. thanks @brb
/priority important-longterm
/approve
/ok-to-test
@kubernetes/sig-cluster-lifecycle-pr-reviews
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brb, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is completely bogus. Are you willing to update this with every kernel update? The numbering scheme has changed and the pace will be much higher exactly due to tests like these.
So please either drop the test completely or make it something really general like [4-9].., [1-9][0-9]..
@jirislaby |
Would it be a good idea have this back ported at least on |
commented on the PR: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes kubeadm preflight checks to work with Linux kernel >= 5.0. The checks currently fail when running on the >= 5.0 kernel:
Does this PR introduce a user-facing change?: