Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update old local tests to use general host executor and local test resource manager #74391

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Update old local tests to use general host executor and local test resource manager #74391

merged 1 commit into from
Mar 5, 2019

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Feb 22, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Update persistent_volumes-local.go to use utils.HostExec/utils.LocalTestResourceManager.
This simplifies the code and makes it more maintainable.

Which issue(s) this PR fixes:

Fixes #71237

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2019
@cofyc
Copy link
Member Author

cofyc commented Feb 22, 2019

/assign @msau42
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019
@msau42
Copy link
Member

msau42 commented Feb 22, 2019

cc @jsafrane @gnufied

@cofyc cofyc changed the title Update old local tests to use general host exec and local tests Update old local tests to use general host exec and local test resource manager Feb 26, 2019
@cofyc cofyc changed the title Update old local tests to use general host exec and local test resource manager Update old local tests to use general host executor and local test resource manager Feb 26, 2019
@cofyc cofyc mentioned this pull request Feb 26, 2019
Closed
@jsafrane
Copy link
Member

jsafrane commented Mar 1, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@msau42
Copy link
Member

msau42 commented Mar 1, 2019

/lgtm cancel
looks like there's some build failure

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019
@cofyc
Copy link
Member Author

cofyc commented Mar 2, 2019

The new test I added in #74716 needs to be updated. I'll fix soon.

@cofyc
Update persistent_volumes-local.go to use utils.HostExec/utils.LocalT…
a81b351 
…estResourceManager.

This simplifies the code and makes it more maintainable.
@cofyc
Copy link
Member Author

cofyc commented Mar 2, 2019

@jsafrane @msau42 Fixed.

@msau42
Copy link
Member

msau42 commented Mar 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit dba8300 into kubernetes:master Mar 5, 2019
@cofyc cofyc mentioned this pull request Mar 13, 2019
Closed
@cofyc cofyc deleted the fix71237-update-old branch May 4, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvance jeffvance Awaiting requested review from jeffvance

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update local PV tests to use the new storage test framework
5 participants
@cofyc @msau42 @jsafrane @k8s-ci-robot @fejta-bot