Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect pod log in fluentd-gcp #74502

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Collect pod log in fluentd-gcp #74502

merged 1 commit into from
Mar 12, 2019

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Feb 25, 2019 •
edited
Loading

Related to #74441.

This is a GCP only change.

This PR:

  1. Configure fluentd-gcp to collect pod logs to stackdriver with k8s_pod resource type.
  2. Configure logrotate for pod logs.

@yujuhong @dchen1107 @bmoyles0117

Support collecting pod logs under /var/log/pods/NAMESPACE_NAME_UID to stackdriver with `k8s_pod` resource type.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2019
@Random-Liu Random-Liu added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2019
@Random-Liu Random-Liu added kind/feature Categorizes issue or PR as related to a new feature. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 25, 2019
@Random-Liu Random-Liu added this to the v1.14 milestone Feb 25, 2019
@Random-Liu Random-Liu added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 25, 2019
@qingling128
Copy link
Contributor

The Fluentd config we use for GKE has been pulled to an internal repo. The OSS version here is only there for legacy gke_container monitored resource.

Started a conversation internally for the next steps.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2019
@Random-Liu
Copy link
Member Author

Started a conversation internally for the next steps.

Discussed offline. We still need this to support GCE Kubernetes users.

@soggiest
Copy link

soggiest commented Mar 7, 2019

Code freeze for 1.14 is coming up in 2 days. This PR is fairly new and needs some reviews. Can we punt this PR to 1.15?

@claurence
Copy link

/hold

1.14 enhancement lead here - given this is a new PR and it's large and we've passed code freeze do we want this PR in the 1.14 release? I see an unanswered question about this above

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2019
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2019
@Random-Liu
Copy link
Member Author

Drop the fluentd update based on #74502 (comment).

Code freeze for 1.14 is coming up in 2 days. This PR is fairly new and needs some reviews. Can we punt this PR to 1.15?

This is a GCE specific small change. Can we still make it in 1.14? It will be reviewed today.

@Random-Liu
Copy link
Member Author

@claurence I scoped down the change. And it is GCP specific that won't affect anyone else. :)

@yujuhong
Copy link
Contributor

yujuhong commented Mar 9, 2019

The change itself looks good.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2019
@Random-Liu
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@claurence
Copy link

@nikopen @spiffxp given this change is now de-scoped to only impact GCP any concerns from y'alls perspective as bug triage and release lead around it landing in 1.14? There are two failing jobs which @Random-Liu is looking into.

@nikopen
Copy link
Contributor

nikopen commented Mar 12, 2019

@claurence this PR is not related to let's say 'core K8S' at all, so it's safe to merge.

For other related pending tickets/PRs, I am collecting them to the daily report for meeting discussion where @spiffxp can decide.

@nikopen
Copy link
Contributor

nikopen commented Mar 12, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2019
@nikopen
Copy link
Contributor

nikopen commented Mar 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit a213886 into kubernetes:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

@piosz piosz Awaiting requested review from piosz

Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Random-Liu @qingling128 @soggiest @claurence @yujuhong @k8s-ci-robot @nikopen