Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Add acceptableFailureRatio to service latency test #74538

Merged
merged 1 commit into from
Mar 1, 2019
Merged

[e2e] Add acceptableFailureRatio to service latency test #74538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/e2e/network/service_latency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ var _ = SIGDescribe("Service endpoints latency", func() {
totalTrials = 200
parallelTrials = 15
minSampleSize = 100

// Acceptable failure ratio for getting service latencies.
acceptableFailureRatio = .05
)

// Turn off rate limiting--it interferes with our measurements.
Expand All @@ -79,7 +82,7 @@ var _ = SIGDescribe("Service endpoints latency", func() {
defer func() { f.ClientSet.CoreV1().RESTClient().(*restclient.RESTClient).Throttle = oldThrottle }()

failing := sets.NewString()
d, err := runServiceLatencies(f, parallelTrials, totalTrials)
d, err := runServiceLatencies(f, parallelTrials, totalTrials, acceptableFailureRatio)
if err != nil {
failing.Insert(fmt.Sprintf("Not all RC/pod/service trials succeeded: %v", err))
}
Expand Down Expand Up @@ -123,7 +126,7 @@ var _ = SIGDescribe("Service endpoints latency", func() {
})
})

func runServiceLatencies(f *framework.Framework, inParallel, total int) (output []time.Duration, err error) {
func runServiceLatencies(f *framework.Framework, inParallel, total int, acceptableFailureRatio float32) (output []time.Duration, err error) {
cfg := testutils.RCConfig{
Client: f.ClientSet,
InternalClient: f.InternalClientset,
Expand Down Expand Up @@ -180,7 +183,11 @@ func runServiceLatencies(f *framework.Framework, inParallel, total int) (output
}
}
if errCount != 0 {
return output, fmt.Errorf("got %v errors", errCount)
framework.Logf("Got %d errors out of %d tries", errCount, total)
errRatio := float32(errCount) / float32(total)
if errRatio > acceptableFailureRatio {
return output, fmt.Errorf("error ratio %g is higher than the acceptable ratio %g", errRatio, acceptableFailureRatio)
}
}
return output, nil
}
Expand Down