kubelet watch-manager test, restore watch-based manager default

[liggitt]

What type of PR is this?
/kind bug

What this PR does / why we need it:

• adds an integration test exercising the watch-based secret manager to ensure http/2 streaming issues are resolved
• restores the watch-based cache manager (reverts Revert kubelet to default to ttl cache secret/configmap behavior #74755)

Which issue(s) this PR fixes:
xref #74412

Does this PR introduce a user-facing change?:

NONE

[dims]

@liggitt x/net is tricky :) see #71501

[liggitt]

@liggitt x/net is tricky :) see #71501

yeah :(

[spiffxp]

/milestone v1.14
Pretty sure we want this to land as part of the v1.14 release

[liggitt]

yeah, will coordinate with @dims and @cblecker on which of this or #71501 go in

[caesarxuchao]

/cc @wenjiaswe

[wenjiaswe]

@liggitt yes, this one is pretty tricky. Along with dependency update in K8s, a bunch of other places need to be updated too: #71501 (comment).

/cc @PrasadG193

[k8s-ci-robot]

@wenjiaswe: GitHub didn't allow me to request PR reviews from the following users: PrasadG193.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@liggitt yes, this one is pretty tricky. Along with dependency update in K8s, a bunch of other places need to be updated too: #71501 (comment).

/cc @PrasadG193

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

since #75289 was able to pick up the go 1.12 level of golang.org/x/net, and feedback from @kubernetes/sig-scalability-misc is that the cache-based manager does not perform as well in scale tests, moving this back into the milestone for consideration

[dims]

/assign @wojtek-t

[wojtek-t]

/lgtm

Thanks a lot for that PR Jordan!

/hold
To ensure that we don't merge it before we're sure we won't be forced to revert golang to 1.11.

[spiffxp]

Unclear if the test failure is related to this PR or not

I0313 16:37:21.458] --- FAIL: TestWatchBasedManager (0.97s)
I0313 16:37:21.459] testserver.go:195: failed to launch server: failed to set default ServerRunOptions: error creating self-signed certificates: unable to generate self signed cert: failed to write cert fixture to cmd/kube-apiserver/app/testing/testdata/127.0.0.1_10.0.0.1_kubernetes.default.svc-kubernetes.default-kubernetes-localhost.crt: open cmd/kube-apiserver/app/testing/testdata/127.0.0.1_10.0.0.1_kubernetes.default.svc-kubernetes.default-kubernetes-localhost.crt: no such file or directory
I0313 16:37:21.459] FAIL

[spiffxp]

/retest

[k8s-ci-robot]

@liggitt: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-godeps	fabb440ba7c739a9a5f62ade6fd6e12cda41b20a	link	/test pull-kubernetes-godeps

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[liggitt]

that's the test this PR added, but it should not be running in that suite... added a missing integration tag into the auto-generated BUILD file to match other tests

[liggitt]

CI is now green, holding pending the go1.12 decision

[wojtek-t]

@liggitt - with the go1.12.1 being merged (and it seems it helps with the issues), can we unhold this one?

[liggitt]

with the go1.12.1 being merged (and it seems it helps with the issues), can we unhold this one?

Yes
/hold cancel

[wojtek-t]

/lgtm