Fix secret/configmap management for terminated pods

[oxddr]

Ref #74412

This PR is based on work of @wojtek-t in #74730

Kubelet no longer watches configmaps and secrets for terminated pods, in worst scenario causing it to not be able to send other requests to kube-apiserver

[k8s-ci-robot]

Hi @oxddr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oxddr]

/assign @yujuhong

[liggitt]

does a pod with a single crashlooping container ever enter failed or succeeded state?

we use secretmanager to get imagepullsecrets which could be needed for pulling the container image on a restart:

kubernetes/pkg/kubelet/kubelet_pods.go

Lines 858 to 866 in dcbe588

	for _, secretRef := range pod.Spec.ImagePullSecrets {
	secret, err := kl.secretManager.GetSecret(pod.Namespace, secretRef.Name)
	if err != nil {
	klog.Warningf("Unable to retrieve pull secret %s/%s for %s/%s due to %v. The image pull may not succeed.", pod.Namespace, secretRef.Name, pod.Namespace, pod.Name, err)
	continue
	}
	pullSecrets = append(pullSecrets, *secret)
	}

[liggitt]

answering my own question, a restarting container keeps a pod in Running:

kubernetes/pkg/apis/core/types.go

Lines 2134 to 2136 in dcbe588

	// PodRunning means the pod has been bound to a node and all of the containers have been started.
	// At least one container is still running or is in the process of being restarted.
	PodRunning PodPhase = "Running"

and succeeded/failed is terminal:

kubernetes/pkg/kubelet/kubelet_pods.go

Lines 1364 to 1372 in dcbe588

	// Check for illegal phase transition
	if pod.Status.Phase == v1.PodFailed || pod.Status.Phase == v1.PodSucceeded {
	// API server shows terminal phase; transitions are not allowed
	if s.Phase != pod.Status.Phase {
	klog.Errorf("Pod attempted illegal phase transition from %s to %s: %v", pod.Status.Phase, s.Phase, s)
	// Force back to phase from the API server
	s.Phase = pod.Status.Phase
	}
	}

[yujuhong]

/lgtm

[oxddr]

I think I need an approval from you, @yujuhong.

[yujuhong]

Please add a release note.

[wojtek-t]

/ok-to-test

@yujuhong - I copied the release-note from my PR.

[yujuhong]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oxddr, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [yujuhong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.