Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #74755: Revert kubelet to default to ttl cache secret/configmap #74841

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Automated cherry pick of #74755: Revert kubelet to default to ttl cache secret/configmap #74841

merged 1 commit into from
Mar 18, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 2, 2019

Cherry pick of #74755 on release-1.13.

#74755: Revert kubelet to default to ttl cache secret/configmap

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2019
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/kubelet sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2019
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 2, 2019
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 2, 2019
@liggitt liggitt added this to the v1.13 milestone Mar 2, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2019

/cc @tpepper @aleksandra-malinowska @yujuhong

@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2019

/retest

neolit123
neolit123 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Mar 4, 2019

/lgtm
/approve

@neolit123
Copy link
Member

neolit123 commented Mar 4, 2019 •
edited
Loading

hm
/approve
EDIT: i wasn't an approver in 1.13.

/assign @fabriziopandini @timothysc

@fabriziopandini
Copy link
Member

/approve
/lgtm
Kubeadm just tests kubelet component config, so this should reflect what sig-node choose as default

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, liggitt, neolit123, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@timothysc
Copy link
Member

@kubernetes/sig-release - ping

@liggitt liggitt mentioned this pull request Mar 7, 2019
Closed
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit da36728 into kubernetes:release-1.13 Mar 18, 2019
@liggitt liggitt deleted the automated-cherry-pick-of-#74755-upstream-release-1.13 branch April 22, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@timothysc timothysc Awaiting requested review from timothysc

@tmrts tmrts Awaiting requested review from tmrts

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@tpepper tpepper Awaiting requested review from tpepper

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@neolit123 neolit123

@fabriziopandini fabriziopandini

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @yujuhong @neolit123 @fabriziopandini @k8s-ci-robot @timothysc @tpepper