remove core repo dependency for auth reconcile command

[juanvallejo]

/kind cleanup

Addresses part of kubernetes/kubectl#80

NONE

/sig cli

cc @soltysh @seans3

[juanvallejo]

Work in progress... Opening now to get feedback mainly on how to approach code duplication for registry/rbac

[soltysh]

The direction is good, can you update the PR, you're missing hack/update-bazel.sh.
/cc @liggitt I think Juan already mentioned you this one some time go, this is copying the functionality from pkg/registry/rbac and make a kubectl copy using external types

[soltysh]

/lgtm
/approve
/priority important-longterm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [soltysh]
• pkg/kubectl/cmd/auth/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

That's a significant amount of duplication. What's the plan for avoiding drift?

Is this required for 1.14?

/hold

[spiffxp]

v1.14 release lead here, this is a size/XXL PR that is attempting to land right before Code Freeze... are you really sure this is a good idea?

Thanks for the /hold @liggitt

[soltysh]

v1.14 release lead here, this is a size/XXL PR that is attempting to land right before Code Freeze... are you really sure this is a good idea?

Is this required for 1.14?

I'm sure, it's not required for 1.14. We'll need to do it eventually to be able to split kubectl out, though. Unless I hear a better option for solving this.

[seans3]

/retest

[seans3]

/retest
/lgtm

[liggitt]

The question at #74879 (comment) is still open. This is a really complex thing to duplicate. As-is, I'd put the chances of the two implementations staying in sync near zero.

The implications of this drifting are worse than human-readable printers not picking up a new field

We have a couple options:

1. relocate the covers/reconcile code to where it can be referenced by an out-of-tree kubectl
2. come up with a way to verify the kubectl copy of the impl doesn't drift

Option 1 is what I expected, and is why @deads2k switched the helpers to use external API types in #63967

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[ncdc]

/uncc

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.