Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cadvisor to v0.33.1. #75140

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Update cadvisor to v0.33.1. #75140

merged 1 commit into from
Mar 8, 2019

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Mar 7, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:

Update cadvisor to v0.33.1 to fix the issue that cadvisor doesn't collect rootfs disk stats for CRI container runtimes.
https://k8s-testgrid.appspot.com/sig-node-containerd#node-e2e

Special notes for your reviewer:
no

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2019
@Random-Liu Random-Liu added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 7, 2019
@Random-Liu Random-Liu added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 7, 2019
@dashpole
Copy link
Contributor

dashpole commented Mar 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@dashpole
Copy link
Contributor

dashpole commented Mar 7, 2019

/assign @dchen1107
for approval

@Random-Liu
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@dchen1107
Copy link
Member

/lgtm
/approve

Thanks for addressing the issue.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@Random-Liu Random-Liu added this to the v1.14 milestone Mar 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 39718e4 into kubernetes:master Mar 8, 2019
@Random-Liu Random-Liu deleted the cadvisor-0-33-1 branch March 8, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeda jbeda Awaiting requested review from jbeda

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dashpole dashpole

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @dashpole @dchen1107 @k8s-ci-robot