Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cadvisor to v0.33.1. #75140

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@Random-Liu
Copy link
Member

Random-Liu commented Mar 7, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:

Update cadvisor to v0.33.1 to fix the issue that cadvisor doesn't collect rootfs disk stats for CRI container runtimes.
https://k8s-testgrid.appspot.com/sig-node-containerd#node-e2e

Special notes for your reviewer:
no

Does this PR introduce a user-facing change?:

none

@Random-Liu Random-Liu force-pushed the Random-Liu:cadvisor-0-33-1 branch from ae1df98 to 74f4579 Mar 7, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Mar 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 7, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Mar 7, 2019

/assign @dchen1107
for approval

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Mar 7, 2019

/test pull-kubernetes-e2e-gce

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Mar 7, 2019

/lgtm
/approve

Thanks for addressing the issue.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Random-Liu Random-Liu added this to the v1.14 milestone Mar 8, 2019

@k8s-ci-robot k8s-ci-robot merged commit 39718e4 into kubernetes:master Mar 8, 2019

17 checks passed

cla/linuxfoundation Random-Liu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Random-Liu Random-Liu deleted the Random-Liu:cadvisor-0-33-1 branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.