make kubectl scale work without a GET if a precodition isn't requested #75210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
needs-sig
k8s-ci-robot
added
area/kubectl
sig/cli
|
@kubernetes/sig-cli-bugs |
|
@soltysh ping |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tedyu
reviewed
Mar 30, 2019
| scale, err := s.scaleNamespacer.Scales(namespace).Get(gr, name) | ||
| if err != nil { | ||
| return "", err | ||
| scale := &autoscalingv1.Scale{ |
There was a problem hiding this comment.
This assignment can be moved into the else block of the preconditions check.
|
This change causes NPE on CRD objects: reference: kubermatic/kubeone#593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl scalewithout preconditions does not need to do a GET. Since GETs may actually fail if there is no current scale, you can create resources which should be scalable and are not. (see #55168 (comment) for the discussion about defaults in CRDs)./kind bug
/priority important-soon