Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster Autoscaler version to 1.13.2 #75291

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Update Cluster Autoscaler version to 1.13.2 #75291

merged 1 commit into from
Mar 21, 2019

Conversation

losipiuk
Copy link
Contributor 

Update Cluster Autoscaler version to 1.13.2. Release notes: https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.2

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2019
@losipiuk losipiuk force-pushed the lo/update-ca-version-1-13-2 branch from da8306d to 89cbdb7 Compare March 12, 2019 14:52
@losipiuk
Copy link
Contributor Author

/kind bug

@losipiuk
Copy link
Contributor Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 12, 2019
@losipiuk
Copy link
Contributor Author

/retest

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Mar 18, 2019
@aleksandra-malinowska
Copy link
Contributor

Looks like the bot isn't updating all the labels:

  • needs-priority (removed it manually since priority was updated),
  • cnfc-cla:yes (still missing even though presubmit passed).

cc @krzyzacy @BenTheElder

@tpepper
Copy link
Member

tpepper commented Mar 18, 2019

This seems like something for which it is probably worth adding a release note.

@losipiuk
Copy link
Contributor Author

This seems like something for which it is probably worth adding a release note.

There is a release notes section in the PR desc. Won't it be picked up automatically on the release?

@BenTheElder
Copy link
Member

/uncc
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2019
@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2019
@mwielgus mwielgus added this to the v1.13 milestone Mar 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 33be0e9 into kubernetes:release-1.13 Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

@vishh vishh Awaiting requested review from vishh

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@losipiuk @aleksandra-malinowska @tpepper @BenTheElder @MaciekPytel @k8s-ci-robot @mwielgus