Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cluster Autoscaler version to 1.13.2 #75291

Merged

Conversation

@losipiuk
Copy link
Contributor

commented Mar 12, 2019

Update Cluster Autoscaler version to 1.13.2. Release notes: https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.2

@losipiuk losipiuk force-pushed the losipiuk:lo/update-ca-version-1-13-2 branch from da8306d to 89cbdb7 Mar 12, 2019

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

/kind bug

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

/priority critical-urgent

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

/retest

@aleksandra-malinowska

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Looks like the bot isn't updating all the labels:

  • needs-priority (removed it manually since priority was updated),
  • cnfc-cla:yes (still missing even though presubmit passed).

cc @krzyzacy @BenTheElder

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

This seems like something for which it is probably worth adding a release note.

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

This seems like something for which it is probably worth adding a release note.

There is a release notes section in the PR desc. Won't it be picked up automatically on the release?

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

/uncc
/check-cla

@MaciekPytel

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwielgus mwielgus added this to the v1.13 milestone Mar 21, 2019

@k8s-ci-robot k8s-ci-robot merged commit 33be0e9 into kubernetes:release-1.13 Mar 21, 2019

17 checks passed

cla/linuxfoundation losipiuk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.