Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when removing docker images #75367

Merged
merged 1 commit into from Mar 16, 2019

Conversation

@feiskyer
Copy link
Member

feiskyer commented Mar 14, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

Dockershim may be panic when deleting images. This PR fixes it by adding a check before using the imageInspect.

Refer kubernetes-sigs/cri-tools#445.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix dockershim panic issues when deleting docker images.

/sig node
/kind bug
/assign @Random-Liu @yujuhong

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Mar 14, 2019

Why does docker return nil with no error? Is this a change caused by docker upgrade?

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Mar 15, 2019

Why does docker return nil with no error? Is this a change caused by docker upgrade?

@yujuhong Right, it comes from Docker after upgrading. Anyway, dockershim shouldn't panic.

/retest

feiskyer added a commit to feiskyer/cri-tools that referenced this pull request Mar 15, 2019

Skip image operations benchmark tests because of dockershim panic
This is actually a workaround for
kubernetes/kubernetes#75367. It would be removed
after the upstream PR #75367 got merged.
@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Mar 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Mar 16, 2019

/milestone v1.14
/priority critical-urgent

Added to v1.14 since it's a critical bug fixes. It should also be cherry picked to stable releases.

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit 0f61968 into kubernetes:master Mar 16, 2019

17 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@feiskyer feiskyer deleted the feiskyer:fix-dockershim-panic branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.