kubeadm: fix "upgrade plan" not defaulting to a "stable" version #75900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the k8s version argument passed to "upgrade plan" is missing the logic should perform the following actions: - fetch a "stable" version from the internet. - if that fails, fallback to the local client version. Currentely the logic fails because the cfg.KubernetesVersion is defaulted to the version of the existing cluster, which then causes an early exit without any ugprade suggestions. See app/cmd/upgrade/common.go::enforceRequirements(): configutil.FetchInitConfigurationFromCluster(..) Fix that by passing the explicit user value that can also be "". This will then make the "offline getter" treat it as an explicit desired upgrade target. In the future it might be best to invert this logic: - if no user k8s version argument is passed - default to the kubeadm version. - if labels are passed (e.g. "stable"), fetch a version from the internet.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
sig/cluster-lifecycle
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rosti
approved these changes
Mar 30, 2019
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 4, 2019
…900-origin-release-1.14 Automated cherry pick of #75900: kubeadm: fix "upgrade plan" not working without k8s version
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the k8s version argument passed to "upgrade plan" is missing
the logic should perform the following actions:
Currentely the logic fails because the cfg.KubernetesVersion is
defaulted to the version of the existing cluster, which
then causes an early exit without any ugprade suggestions.
See
app/cmd/upgrade/common.go::enforceRequirements():configutil.FetchInitConfigurationFromCluster(..)Fix that by passing the explicit user value that can also be "".
This will then make the "offline getter" treat it as an explicit
desired upgrade target.
In the future it might be best to invert this logic:
version.
internet.
Which issue(s) this PR fixes:
Fixes #kubernetes/kubeadm#1470
Special notes for your reviewer:
this bug only affects "plan", not the actual upgrades.
Does this PR introduce a user-facing change?:
/kind bug
/priority critical-urgent
/assign @fabriziopandini @rosti
@kubernetes/sig-cluster-lifecycle-pr-reviews