Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map write access in Portworx create volume call #76341

Merged

Conversation

@harsh-px
Copy link
Contributor

commented Apr 9, 2019

Fixes #76340

Signed-off-by: Harsh Desai harsh@portworx.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a crash in controller manager due to concurrent map access in the Portworx volume driver create call

Which issue(s) this PR fixes:
Fixes #76340

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

Fix issue in Portworx volume driver causing controller manager to crash
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Hi @harsh-px. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and verult Apr 9, 2019

@harsh-px harsh-px force-pushed the harsh-px:fix-concurrent-access-master branch from 19348ee to cacf0e4 Apr 9, 2019

Fix concurrent map access in Portworx create volume call
Fixes #76340

Signed-off-by: Harsh Desai <harsh@portworx.com>

@harsh-px harsh-px force-pushed the harsh-px:fix-concurrent-access-master branch from fedc10a to 17dd598 Apr 9, 2019

@harsh-px

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

/assign @gnufied

@harsh-px harsh-px changed the title Fix concurrent map access in Portworx create volume call Fix concurrent map write access in Portworx create volume call Apr 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/ok-to-test
/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/kind bug
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harsh-px, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harsh-px

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

/retest

1 similar comment
@harsh-px

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit d424bed into kubernetes:master Apr 15, 2019

19 of 20 checks passed

pull-kubernetes-e2e-gce-csi-serial Job triggered.
Details
cla/linuxfoundation harsh-px authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request May 2, 2019

Merge pull request #76961 from harsh-px/automated-cherry-pick-of-#763…
…41-upstream-release-1.13

Automated cherry pick of #76341: Fix concurrent map access in Portworx create volume call

k8s-ci-robot added a commit that referenced this pull request May 8, 2019

Merge pull request #76960 from harsh-px/automated-cherry-pick-of-#763…
…41-upstream-release-1.14

Automated cherry pick of #76341: Fix concurrent map access in Portworx create volume call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.