Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrent map write access in Portworx create volume call #76341

Merged
merged 1 commit into from Apr 15, 2019
Merged

Fix concurrent map write access in Portworx create volume call #76341

merged 1 commit into from Apr 15, 2019

Conversation

harsh-px
Copy link
Contributor

@harsh-px harsh-px commented Apr 9, 2019

Fixes #76340

Signed-off-by: Harsh Desai harsh@portworx.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a crash in controller manager due to concurrent map access in the Portworx volume driver create call

Which issue(s) this PR fixes:
Fixes #76340

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

Fix issue in Portworx volume driver causing controller manager to crash

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @harsh-px. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2019
@harsh-px harsh-px force-pushed the fix-concurrent-access-master branch from 19348ee to cacf0e4 Compare April 9, 2019 19:11
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2019
Fix concurrent map access in Portworx create volume call
17dd598 
Fixes kubernetes#76340

Signed-off-by: Harsh Desai <harsh@portworx.com>
@harsh-px harsh-px force-pushed the fix-concurrent-access-master branch from fedc10a to 17dd598 Compare April 9, 2019 19:13
@harsh-px
Copy link
Contributor Author

harsh-px commented Apr 9, 2019

/assign @gnufied

@harsh-px harsh-px changed the title Fix concurrent map access in Portworx create volume call Fix concurrent map write access in Portworx create volume call Apr 11, 2019
@liggitt
Copy link
Member

liggitt commented Apr 15, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@liggitt
Copy link
Member

liggitt commented Apr 15, 2019

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harsh-px, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@harsh-px
Copy link
Contributor Author

/retest

1 similar comment
@harsh-px
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d424bed into kubernetes:master Apr 15, 2019
This was referenced Apr 23, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
@k8s-ci-robot
Merge pull request #76961 from harsh-px/automated-cherry-pick-of-#763…
798e669 
…41-upstream-release-1.13

Automated cherry pick of #76341: Fix concurrent map access in Portworx create volume call
k8s-ci-robot added a commit that referenced this pull request May 8, 2019
@k8s-ci-robot
Merge pull request #76960 from harsh-px/automated-cherry-pick-of-#763…
3a208b6 
…41-upstream-release-1.14

Automated cherry pick of #76341: Fix concurrent map access in Portworx create volume call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@verult verult Awaiting requested review from verult

Assignees

@gnufied gnufied

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix concurrent map read and map write in Portworx driver
4 participants
@harsh-px @k8s-ci-robot @liggitt @gnufied