Also push .sha1 for devel builds #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @filbranden |
| local -r file=$1 | ||
| local -r newsum=$2 | ||
|
|
||
| if [ ! -e "${file}.sha1" ]; then |
There was a problem hiding this comment.
Please always use [[ ... ]] in bash, it's a built-in and allows for more flexible syntax.
In this case, you can use || instead of the if !.
[[ -e "${file}.sha1" ]] || return 1
|
The usual nitpicks, otherwise looks good and makes sense. |
|
Let me know when it's ready to take another look... |
|
Sorry, got sidetracked by other stuff today, will fix it up soon. :) |
And adds a .sha1 cache file to indicate what file was already pushed to GCS, and how to force it if not, removing a few seconds off a kube-up/push if you're just cycling. With this and kubernetes#7602, all TAR_URLS will have a .sha1 as well.
zmerlynn
force-pushed
the
upload_hash_in_util
branch
from
8600ae5
to
0c107e4
Compare
|
PTAL. I think this addressed everything. |
filbranden
added a commit
that referenced
this pull request
May 6, 2015
Also push .sha1 for devel builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adds a .sha1 cache file to indicate what file was already pushed
to GCS, and how to force it if not, removing a few seconds off a
kube-up/push if you're just cycling.
With this and #7602, all TAR_URLS will have a .sha1 as well.