Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-home juju related source #76628

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@kwmonroe
Copy link
Contributor

commented Apr 15, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Source from the ./cluster/juju tree has been moved to a new Charmed Kubernetes org. This PR cleans out the juju subdirectory and adds a notice about where the source went.

Which issue(s) this PR fixes:

Fixes kubernetes/community#2892

Special notes for your reviewer:
When merged, the only files remaining in the juju subdirectory will be .gitignore, OWNERS, and README.md.

Does this PR introduce a user-facing change?:

Juju provider source moved to the Charmed Kubernetes org
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Hi @kwmonroe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

/ok-to-test

thanks @kwmonroe

/assign @liggitt

@kwmonroe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

/assign @Cynerva

@Cynerva

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

/approve
/lgtm

👍

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, kwmonroe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Source from the ./cluster/juju tree has been moved to a new Charmed Kubernetes org. This PR cleans out the juju subdirectory and adds a notice about where the source went.

thanks for the cleanup @kwmonroe
🎉

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 16, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 02ffdd1 into kubernetes:master Apr 16, 2019

20 checks passed

cla/linuxfoundation kwmonroe authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@kwmonroe kwmonroe deleted the kwmonroe:rehome-juju branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.