remove unused functions & types in test/e2e/framework/util.go #76631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/e2e-test-framework
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/assign @neolit123 @johnSchnake @stevesloka @oomichi |
k8s-ci-robot
added
the
lgtm
|
/uncc |
johnSchnake
approved these changes
Apr 16, 2019
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
oomichi
reviewed
Apr 16, 2019
| } | ||
|
|
||
| // GetServerArchitecture fetches the architecture of the cluster's apiserver. | ||
| func GetServerArchitecture(c clientset.Interface) string { |
There was a problem hiding this comment.
| @@ -362,12 +335,6 @@ func SkipIfMultizone(c clientset.Interface) { | |||
| } | |||
| } | |||
|
|
|||
| func SkipUnlessClusterMonitoringModeIs(supportedMonitoring ...string) { | |||
There was a problem hiding this comment.
| @@ -386,22 +353,6 @@ func SkipUnlessNodeOSDistroIs(supportedNodeOsDistros ...string) { | |||
| } | |||
| } | |||
|
|
|||
| func SkipUnlessSecretExistsAfterWait(c clientset.Interface, name, namespace string, timeout time.Duration) { | |||
There was a problem hiding this comment.
| @@ -443,15 +394,6 @@ func ProviderIs(providers ...string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func ClusterMonitoringModeIs(monitoringModes ...string) bool { | |||
There was a problem hiding this comment.
SkipUnlessClusterMonitoringModeIs is only caller as https://cs.k8s.io/?q=ClusterMonitoringModeIs&i=nope&files=&repos=kubernetes/kubernetes and that is removed as the above.
| // WaitForPodsSuccess waits till all labels matching the given selector enter | ||
| // the Success state. The caller is expected to only invoke this method once the | ||
| // pods have been created. | ||
| func WaitForPodsSuccess(c clientset.Interface, ns string, successPodLabels map[string]string, timeout time.Duration) error { |
There was a problem hiding this comment.
|
|
||
| // KubectlVersionGTE returns true if the kubectl version is greater than or | ||
| // equal to v. | ||
| func KubectlVersionGTE(v *utilversion.Version) (bool, error) { |
There was a problem hiding this comment.
as https://cs.k8s.io/?q=KubectlVersionGTE&i=nope&files=&repos=kubernetes/kubernetes SkipUnlessKubectlVersionGTE is only caller and that is removed on the above.
| @@ -3358,40 +3195,6 @@ func isNotRestartAlwaysMirrorPod(p *v1.Pod) bool { | |||
| return p.Spec.RestartPolicy != v1.RestartPolicyAlways | |||
| } | |||
|
|
|||
| // Waits for the number of events on the given object to reach a desired count. | |||
| func WaitForEvents(c clientset.Interface, ns string, objOrRef runtime.Object, desiredEventsCount int) error { | |||
There was a problem hiding this comment.
| } | ||
|
|
||
| // Waits for the number of events on the given object to be at least a desired count. | ||
| func WaitForPartialEvents(c clientset.Interface, ns string, objOrRef runtime.Object, atLeastEventsCount int) error { |
There was a problem hiding this comment.
| // as the target for networking connectivity checks. The ip address | ||
| // of the created pod will be returned if the pod is launched | ||
| // successfully. | ||
| func LaunchWebserverPod(f *Framework, podName, nodeName string) (ip string) { |
There was a problem hiding this comment.
| @@ -4660,24 +4428,6 @@ func parseSystemdServices(services string) string { | |||
| return strings.TrimSpace(strings.Replace(services, ",", " ", -1)) | |||
| } | |||
|
|
|||
| func UpdatePodWithRetries(client clientset.Interface, ns, name string, update func(*v1.Pod)) (*v1.Pod, error) { | |||
There was a problem hiding this comment.
|
Thanks for the thorough check @oomichi!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim kiman@vmware.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
First pass at cleaning up test/e2e/framework/util.go as part of #76206. Longer term we're trying to split up test/e2e/framework/util.go into separate packages for better discovery/readability. This PR is just a first pass to remove any methods/functions/structs that aren't being used.
Which issue(s) this PR fixes:
Part of #76206
Special notes for your reviewer:
Does this PR introduce a user-facing change?: