github.com/onsi/ginkgo v1.6.0

[liggitt]

Bumps ginkgo to the version preferred by our current level of github.com/onsi/gomega

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

/area code-organization
/sig testing

/cc @dims
for dependency bump

/cc @BenTheElder
for testing dependency

/cc @cblecker
for license addition

[liggitt]

/priority important-soon

with this bump, all our dependencies are at their natural versions with the exception of golang/x/{sys,tools} which are at the go1.12 branch levels

[liggitt]

/hold
for review by all assigned

[dims]

@liggitt looks like we will have 2 fsnotify packages with this change (with same code?)

• gopkg.in/fsnotify.v1
• github.com/fsnotify/fsnotify

Anything we can do to collapse them?

[liggitt]

Anything we can do to collapse them?

We'd have transitive dependencies on both (github.com/spf13/viper/viper.go uses github.com/fsnotify/fsnotify), so not easily

[dims]

@liggitt other than that the tomb and tail dependency seem ok (other than a note in kubernetes/node-problem-detector#3 where folks ran into a problem with hpcloud/tail)

[liggitt]

@liggitt other than that the tomb and tail dependency seem ok (other than a note in kubernetes/node-problem-detector#3 where folks ran into a problem with hpcloud/tail)

it looks like that's only in use by the ginkgo DebugParallel function, which I don't see us using

[liggitt]

/retest

[liggitt]

hmm... this license doesn't have a recognized name... @cblecker, does the text match a known/acceptable license?

[liggitt]

ah, looks to match the bsd 3-clause license, but extra eyes are appreciated

[neolit123]

looks like the 3 clause BSD:
https://opensource.org/licenses/BSD-3-Clause

Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.

is not exactly something that certain parties want to comply with.
i'd ask the license experts.

[liggitt]

we already have 14 other dependencies with this license, fyi

[neolit123]

in that case we can assume it's OK.

[BenTheElder]

FYI https://github.com/kubernetes/community/blob/b1851114db65091eff064cee2b786826b203c231/contributors/devel/sig-architecture/godep.md#reviewing-and-approving-dependency-changes ->
https://github.com/cncf/foundation/blob/master/whitelist-policy.md#approved-licenses-for-whitelist

3 clause BSD is approved

[neolit123]

nice list, thanks.

[cblecker]

/lgtm
/approve

[BenTheElder]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]
• staging/src/k8s.io/api/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/hold cancel