Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated centos/local support #76711

Merged
merged 1 commit into from Apr 18, 2019
Merged

Remove deprecated centos/local support #76711

merged 1 commit into from Apr 18, 2019

Conversation

dims
Copy link
Member

@dims dims commented Apr 17, 2019

Change-Id: I4a451ec0125c05e66202daf781a4e5a1d895efb4

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We deprecated the providers back in k8s 1.8 release via commit 89bf771

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-up.sh no longer supports "centos" and "local" providers

@dims
Remove deprecated centos/local support
8762bc3 
Change-Id: I4a451ec0125c05e66202daf781a4e5a1d895efb4
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 17, 2019
@dims dims requested review from mikedanese and spiffxp April 17, 2019 15:09
@dims
Copy link
Member Author

dims commented Apr 17, 2019

/priority important-soon
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2019
@dims
Copy link
Member Author

dims commented Apr 17, 2019

/assign @mikedanese @spiffxp

@zouyee
Copy link
Member

zouyee commented Apr 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@dims
Copy link
Member Author

dims commented Apr 18, 2019

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 18, 2019

/approve

In the release note, note which release they were deprecated in

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit c58864d into kubernetes:master Apr 18, 2019
@chendave
Copy link
Member

Could you pls let me know what's the right way to run e2e testcase with local cluster? The document below seems outdated
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md.

@chendave
Copy link
Member

ping @dims

@zhlhahaha zhlhahaha mentioned this pull request Aug 13, 2019
Closed
@neolit123 neolit123 mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouyee zouyee zouyee approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@spiffxp spiffxp Awaiting requested review from spiffxp

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@spiffxp spiffxp

@liggitt liggitt

@mikedanese mikedanese

@zouyee zouyee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @zouyee @liggitt @k8s-ci-robot @chendave @spiffxp @mikedanese