Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated centos/local support #76711

Merged

Conversation

@dims
Copy link
Member

commented Apr 17, 2019

Change-Id: I4a451ec0125c05e66202daf781a4e5a1d895efb4

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We deprecated the providers back in k8s 1.8 release via commit 89bf771

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-up.sh no longer supports "centos" and "local" providers
Remove deprecated centos/local support
Change-Id: I4a451ec0125c05e66202daf781a4e5a1d895efb4
@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

/priority important-soon
/sig testing

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@zouyee

zouyee approved these changes Apr 18, 2019

@zouyee

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

/lgtm

@dims

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

/approve

In the release note, note which release they were deprecated in

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c58864d into kubernetes:master Apr 18, 2019

20 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.