Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin GCE Windows node image to 1809 v20190312. #76722

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Pin GCE Windows node image to 1809 v20190312. #76722

merged 1 commit into from
Apr 18, 2019

Conversation

pjh
Copy link
Contributor

@pjh pjh commented Apr 17, 2019 •
edited
Loading

/kind bug

This is to work around #76666.

Windows nodes on GCE use a known-working 1809 image rather than the latest 1809 image.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2019
@pjh
Copy link
Contributor Author

pjh commented Apr 17, 2019

/assign yujuhong

@pjh
Copy link
Contributor Author

pjh commented Apr 17, 2019

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2019
@yujuhong
Copy link
Contributor

Please add a release note. We need to patch 1.14 too.

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Apr 17, 2019
@pjh
Copy link
Contributor Author

pjh commented Apr 17, 2019

I'm hoping this is a temporary change. Is it ok to omit the release note for master?

When cherry-picked to 1.14 I know that a release note will be required.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 17, 2019
@pjh
Copy link
Contributor Author

pjh commented Apr 17, 2019

Release note added.

@yujuhong
Copy link
Contributor

/lgtm
/approve

@mtaufen

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@yujuhong yujuhong added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 17, 2019
@yujuhong
Copy link
Contributor

/retest

1 similar comment
@pjh
Copy link
Contributor Author

pjh commented Apr 18, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 257e686 into kubernetes:master Apr 18, 2019
@pjh pjh mentioned this pull request Apr 30, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
@k8s-ci-robot
Merge pull request #77285 from pjh/automated-cherry-pick-of-#76722-up…
1023bb9 
…stream-release-1.14

Automated cherry pick of #76722: Pin GCE Windows node image to 1809 v20190312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjh @yujuhong @k8s-ci-robot