Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GCE Windows node image to 1809 v20190312. #76722

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@pjh
Copy link
Contributor

commented Apr 17, 2019

/kind bug

This is to work around #76666.

Windows nodes on GCE use a known-working 1809 image rather than the latest 1809 image.
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

/assign yujuhong

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows and removed needs-sig labels Apr 17, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Please add a release note. We need to patch 1.14 too.

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

I'm hoping this is a temporary change. Is it ok to omit the release note for master?

When cherry-picked to 1.14 I know that a release note will be required.

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Release note added.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

/lgtm
/approve

@mtaufen

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

/retest

1 similar comment
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 257e686 into kubernetes:master Apr 18, 2019

20 checks passed

cla/linuxfoundation pjh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request May 2, 2019

Merge pull request #77285 from pjh/automated-cherry-pick-of-#76722-up…
…stream-release-1.14

Automated cherry pick of #76722: Pin GCE Windows node image to 1809 v20190312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.