Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint failures of pkg/kubelet/dockershim/cm #76925

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion hack/.golint_failures
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ pkg/kubelet/container
pkg/kubelet/container/testing
pkg/kubelet/custommetrics
pkg/kubelet/dockershim
pkg/kubelet/dockershim/cm
pkg/kubelet/dockershim/libdocker
pkg/kubelet/dockershim/network
pkg/kubelet/dockershim/network/cni
Expand Down
2 changes: 2 additions & 0 deletions pkg/kubelet/dockershim/cm/container_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ limitations under the License.

package cm

// ContainerManager is an interface that abstracts the basic operations of a
// container manager.
type ContainerManager interface {
Start() error
}
1 change: 1 addition & 0 deletions pkg/kubelet/dockershim/cm/container_manager_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ var (
memoryCapacityRegexp = regexp.MustCompile(`MemTotal:\s*([0-9]+) kB`)
)

// NewContainerManager creates a new instance of ContainerManager
func NewContainerManager(cgroupsName string, client libdocker.Interface) ContainerManager {
return &containerManager{
cgroupsName: cgroupsName,
Expand Down
1 change: 1 addition & 0 deletions pkg/kubelet/dockershim/cm/container_manager_unsupported.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
type unsupportedContainerManager struct {
}

// NewContainerManager creates a new instance of ContainerManager
func NewContainerManager(_ string, _ libdocker.Interface) ContainerManager {
return &unsupportedContainerManager{}
}
Expand Down
1 change: 1 addition & 0 deletions pkg/kubelet/dockershim/cm/container_manager_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
type containerManager struct {
}

// NewContainerManager creates a new instance of ContainerManager
func NewContainerManager(_ string, _ libdocker.Interface) ContainerManager {
return &containerManager{}
}
Expand Down