refactor: move wait for endpoints to new pkg #77156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
draveness
force-pushed
the
feature/refactor-util-endpoints
branch
from
81e5033
to
cc26379
Compare
k8s-ci-robot
added
area/e2e-test-framework
|
/cc @andrewsykim |
draveness
commented
Apr 27, 2019
| @@ -26,13 +26,14 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "k8s.io/api/core/v1" | |||
| v1 "k8s.io/api/core/v1" | |||
There was a problem hiding this comment.
Related to #77045
|
/test pull-kubernetes-e2e-gce-100-performance |
andrewsykim
reviewed
Apr 27, 2019
test/e2e/framework/endpoints/wait.go
Outdated
|
|
||
| // WaitForEndpoint waits for the specified endpoint to be ready. | ||
| func WaitForEndpoint(c clientset.Interface, ns, name string) error { | ||
| for t := time.Now(); time.Since(t) < framework.EndpointRegisterTimeout; time.Sleep(framework.Poll) { |
There was a problem hiding this comment.
Should we also move EndpointRegisterTimeout in here?
There was a problem hiding this comment.
Yeah, I moved EndpointRegisterTimeout to this file and made it private since no one else uses this constant.
draveness
force-pushed
the
feature/refactor-util-endpoints
branch
from
cc26379
to
774c15f
Compare
10 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: draveness, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/priority backlog
What this PR does / why we need it:
#76206
#77095
Does this PR introduce a user-facing change?: