Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify godeps failure on 1.13 #77241

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix verify godeps failure on 1.13 #77241

merged 1 commit into from
Apr 30, 2019
+1 −1

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Apr 29, 2019

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
github.com/evanphx/json-patch added a new tag at the same sha this
morning: https://github.com/evanphx/json-patch/releases/tag/v4.2.0

This confused godeps. This PR updates our file to match godeps
expectation.

Which issue(s) this PR fixes:
Fixes: #77238

Does this PR introduce a user-facing change?:

NONE

/priority critical-urgent
/sig testing
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 29, 2019
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2019
@mtaufen mtaufen changed the base branch from master to release-1.13 April 29, 2019 23:30
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2019
@mtaufen
Fix verify godeps failure for 1.13
271f793 
github.com/evanphx/json-patch added a new tag at the same sha this
morning: https://github.com/evanphx/json-patch/releases/tag/v4.2.0

This confused godeps. This PR updates our file to match godeps
expectation.

Fixes issue 77238
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2019
@mtaufen mtaufen mentioned this pull request Apr 29, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

/assign @dougm @aleksandra-malinowska @tpepper
Can one of you please approve the cherry-pick?

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2019
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 30, 2019 •
edited
Loading

@mtaufen: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-cross
pull-kubernetes-e2e-gce-100-performance fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-storage-slow fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-conformance-image-test fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-conformance-image-test
pull-kubernetes-dependencies fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-dependencies
pull-kubernetes-local-e2e fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-local-e2e
pull-kubernetes-e2e-gce-csi-serial fb24b3e2f03747a13e4fc82333cb71fa13b1613f link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ad89333 into kubernetes:release-1.13 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@dougm dougm

@liggitt liggitt

@cblecker cblecker

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtaufen @liggitt @cblecker @k8s-ci-robot @fejta-bot @dougm @tpepper @aleksandra-malinowska