Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #69631: use k8s.gcr.io/pause instead of kubernetes/pause #77292

Merged
merged 1 commit into from
May 2, 2019
Merged

Automated cherry pick of #69631: use k8s.gcr.io/pause instead of kubernetes/pause #77292

merged 1 commit into from
May 2, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 1, 2019 •
edited
Loading

Cherry pick of #69631 on release-1.12.

#69631: use k8s.gcr.io/pause instead of kubernetes/pause

Use k8s.gcr.io/pause image instead of kubernetes/pause in test framework

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 1, 2019
@cblecker
Copy link
Member Author

cblecker commented May 1, 2019

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 1, 2019
@cblecker
Copy link
Member Author

cblecker commented May 1, 2019

/assign @spiffxp @dims

@cblecker
Copy link
Member Author

cblecker commented May 1, 2019

/assign @feiskyer
This is to ensure we don't have any references to this deprecated image in any supported version: https://groups.google.com/d/msg/kubernetes-dev/3mDGndOkZDQ/gy7pb1baAAAJ

@cblecker
Copy link
Member Author

cblecker commented May 1, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member

dims commented May 1, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer feiskyer removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 2, 2019
@feiskyer feiskyer added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3146b27 into kubernetes:release-1.12 May 2, 2019
@cblecker cblecker deleted the automated-cherry-pick-of-#69631-upstream-release-1.12 branch May 2, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

Assignees

@dims dims

@spiffxp spiffxp

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cblecker @dims @k8s-ci-robot @spiffxp @feiskyer @Huang-Wei