Update iptables.IsNotFoundError for iptables-nft error messages #77303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/bug
danwinship
force-pushed
the
iptables-is-not-found-error
branch
2 times, most recently
from
bdc6cbe
to
3fa6285
Compare
danwinship
force-pushed
the
iptables-is-not-found-error
branch
from
3fa6285
to
4d77d3e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
iptables-nft mode in iptables 1.8+ does not print exactly the same errors as "iptables-legacy" / iptables < 1.8, so
iptables.IsNotFoundError()was sometimes incorrect.Pre-#76109 this would result in "not found" errors being logged at startup that were not actually errors. (And then kube-proxy would run fine after that.) Post-#76109 this has no effect on normal kube-proxy operation but means
kube-proxy --cleanupwould erroneously log errors and then exit with a non-0 status.Does this PR introduce a user-facing change?:
/cc @dcbw @squeed