Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iptables.IsNotFoundError for iptables-nft error messages #77303

Merged

Conversation

@danwinship
Copy link
Contributor

commented May 1, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
iptables-nft mode in iptables 1.8+ does not print exactly the same errors as "iptables-legacy" / iptables < 1.8, so iptables.IsNotFoundError() was sometimes incorrect.

Pre-#76109 this would result in "not found" errors being logged at startup that were not actually errors. (And then kube-proxy would run fine after that.) Post-#76109 this has no effect on normal kube-proxy operation but means kube-proxy --cleanup would erroneously log errors and then exit with a non-0 status.

Does this PR introduce a user-facing change?:

Fixes spurious error messages about failing to clean up iptables rules when using iptables 1.8.

/cc @dcbw @squeed

@k8s-ci-robot k8s-ci-robot requested review from dcbw and squeed May 1, 2019

@danwinship danwinship force-pushed the danwinship:iptables-is-not-found-error branch 2 times, most recently from bdc6cbe to 3fa6285 May 1, 2019

@danwinship danwinship force-pushed the danwinship:iptables-is-not-found-error branch from 3fa6285 to 4d77d3e May 1, 2019

@dcbw

This comment has been minimized.

Copy link
Member

commented May 1, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 53b41dd into kubernetes:master May 1, 2019

20 checks passed

cla/linuxfoundation danwinship authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@danwinship danwinship deleted the danwinship:iptables-is-not-found-error branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.