Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rollout restart for statefulset and daemonset #77423

Merged

Conversation

@apelisse
Copy link
Member

commented May 3, 2019

Specifically, DaemonSet and Statefulset

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #13488

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`kubectl rollout restart` now works for daemonsets and statefulsets.
@apelisse

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

/assign @janetkuo

@apelisse

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/priority important-longterm

@apelisse apelisse force-pushed the apelisse:rollout-restart-other-workloads branch from 33ec13a to b4ad035 May 10, 2019

@apelisse

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

OK I've added the test, should be ready for review @janetkuo

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apelisse apelisse force-pushed the apelisse:rollout-restart-other-workloads branch from b4ad035 to 145935d May 16, 2019

@janetkuo

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/lgtm

Thank you!!!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit 6dfc996 into kubernetes:master May 16, 2019

20 checks passed

cla/linuxfoundation apelisse authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.