Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 77527 - Build unstripped binaries on-demand #77549

Closed
wants to merge 1 commit into from

Conversation

YoubingLi
Copy link

@YoubingLi YoubingLi commented May 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Build un-stripped binaries on-demand

Which issue(s) this PR fixes:

Fixes #77527

Special notes for your reviewer:

If the user prefers to build un-stripped binaries, "-s" and "-w" are ignored in ldflags even they have been specified in GOLDFLAGS

Does this PR introduce a user-facing change?:
NONE

     NONE

/assign @dims
/assign @cblecker

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 7, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @YoubingLi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from fejta and spiffxp May 7, 2019 14:56
@spiffxp
Copy link
Member

spiffxp commented May 7, 2019

/ok-to-test
/priority important-soon
/sig release

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2019
# binaries are built as unstripped
for flag in ${GOGCFLAGS:-}; do
[[ "${flag}" = "-N" ]] && nflag=1
[[ "${flag}" = "-l" ]] && lflag=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do -N and -l come from. i can't seem to find them under:
https://golang.org/cmd/link/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123

The user specified in GOGCFLAGS and please refer the explaination in Makefile from Line 81 to Line 84

https://github.com/kubernetes/kubernetes/blob/master/build/root/Makefile#L81~L84

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YoubingLi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dims

If they are not already assigned, you can assign the PR to them by writing /assign @dims in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented May 8, 2019

/close

please see comment in #77527 (comment)

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

/close

please see comment in #77527 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No debug info when building Kubernetes source code with make all GOGCFLAGS="-N -l"
5 participants