Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #69828: Make CreatePrivilegedPSPBinding reentrant #77555

Merged
merged 1 commit into from
May 8, 2019
Merged

Automated cherry pick of #69828: Make CreatePrivilegedPSPBinding reentrant #77555

merged 1 commit into from
May 8, 2019

Conversation

BenTheElder
Copy link
Member

Cherry pick of #69828 on release-1.12.

#69828: Make CreatePrivilegedPSPBinding reentrant

@ironcladlou @BenTheElder
Make CreatePrivilegedPSPBinding reentrant
3ca2279 
Make CreatePrivilegedPSPBinding reentrant so tests using it (e.g. DNS) can be
executed more than once against a cluster. Without this change, such tests will
fail because the PSP already exists, short circuiting test setup.
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #69828.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2019
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 7, 2019
@BenTheElder
Copy link
Member Author

This fixes e2e test behavior, without it tests that setup a privileged PSP can fail on the PSP already existing.

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 7, 2019
@BenTheElder
Copy link
Member Author

/priority important-soon
this is blocking some testing work on excessive test setup flakes.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@BenTheElder
Copy link
Member Author

/assign @spiffxp

@BenTheElder BenTheElder mentioned this pull request May 7, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented May 7, 2019

/retest

@BenTheElder
Copy link
Member Author

/retest
:/

@BenTheElder BenTheElder mentioned this pull request May 7, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented May 7, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@BenTheElder
Copy link
Member Author

/cc @feiskyer

PTAL, this shouldn't affect the release but it does prevent (potentially lots of) spurious test failures.
I'm suprised this wasn't cherry-picked previously.

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer May 7, 2019 22:59
@feiskyer
Copy link
Member

feiskyer commented May 8, 2019

/test pull-kubernetes-verify

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 8, 2019
feiskyer
feiskyer approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry pick approved

@k8s-ci-robot k8s-ci-robot merged commit eb8f835 into kubernetes:release-1.12 May 8, 2019
@BenTheElder
Copy link
Member Author

Thank you all 😀

@BenTheElder BenTheElder deleted the automated-cherry-pick-of-#69828-upstream-release-1.12 branch May 8, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@bowei bowei Awaiting requested review from bowei

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BenTheElder @k8s-ci-robot @spiffxp @feiskyer @ironcladlou