Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #77426: Remove terminated pod from summary api. #77640

Merged
merged 1 commit into from May 10, 2019
Merged

Automated cherry pick of #77426: Remove terminated pod from summary api. #77640

merged 1 commit into from May 10, 2019

Conversation

Random-Liu
Copy link
Member

Cherry pick of #77426 on release-1.14.

#77426: Remove terminated pod from summary api.

@Random-Liu
Remove terminated pod from summary api.
4ecab5e 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2019
@Random-Liu Random-Liu added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 9, 2019
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 9, 2019
@Random-Liu Random-Liu added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 9, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 9, 2019
@Random-Liu Random-Liu added this to the v1.14 milestone May 9, 2019
feiskyer
feiskyer reviewed May 9, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@hoegaarden
Copy link
Contributor

hoegaarden commented May 9, 2019 •
edited

This feels like a significant-enough user-facing change for a release-note. What do you all think?

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 10, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 10, 2019
@tpepper
Copy link
Member

tpepper commented May 10, 2019

This feels like a significant-enough user-facing change for a release-note. What do you all think?

It'll come from the parent master PR.

@k8s-ci-robot k8s-ci-robot merged commit 39c09f8 into kubernetes:release-1.14 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@feiskyer feiskyer

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Random-Liu @k8s-ci-robot @hoegaarden @tpepper @feiskyer @aleksandra-malinowska @yujuhong