Improve error message when user provide invalid certificate key #77768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
|
/assign @fabriziopandini |
|
nice |
k8s-ci-robot
added
the
lgtm
SataQiu
approved these changes
May 11, 2019
neolit123
reviewed
May 11, 2019
| @@ -89,7 +89,8 @@ func UploadCerts(client clientset.Interface, cfg *kubeadmapi.InitConfiguration, | |||
| fmt.Printf("[upload-certs] Storing the certificates in Secret %q in the %q Namespace\n", kubeadmconstants.KubeadmCertsSecret, metav1.NamespaceSystem) | |||
| decodedKey, err := hex.DecodeString(key) | |||
| if err != nil { | |||
| return err | |||
| klog.Error("[upload-certs] Failed decoding certificate key.") | |||
| return errors.Wrap(err, "error decoding certificate key") | |||
There was a problem hiding this comment.
isn't this sufficient?
return errors.Wrap(err, "error decoding certificate key")
the error should bubble up and be printed.
i think with this change it will be printed 2times - once with klog once from cobra.
| @@ -215,6 +216,7 @@ func DownloadCerts(client clientset.Interface, cfg *kubeadmapi.InitConfiguration | |||
|
|
|||
| decodedKey, err := hex.DecodeString(key) | |||
| if err != nil { | |||
| klog.Error("[download-certs] Failed decoding certificate key.") | |||
| return errors.Wrap(err, "error decoding certificate key") | |||
fabriziopandini
approved these changes
May 12, 2019
There was a problem hiding this comment.
@yagonobre many thanks for the quick fix, really appreciated!
Please address @neolit123 comments an then this one can be approved for me
k8s-ci-robot
removed
the
lgtm
|
@neolit123 @fabriziopandini updated! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, yagonobre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Improve error message, more details on https://kubernetes.slack.com/archives/C2P1JHS2E/p1557408526235800
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/priority backlog