Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap mapfile out in update-codegen #77783

Merged
merged 1 commit into from May 12, 2019

Conversation

@cblecker
Copy link
Member

commented May 11, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Don't use mapfile in hack/update-codegen.sh. Fixes compatibility with bash 3.

Was erroneously introduced in #76482.

Does this PR introduce a user-facing change?:

NONE
@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

/priority important-soon
/sig api-machinery

@BenTheElder
Copy link
Member

left a comment

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label May 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker force-pushed the cblecker:codegen-mapfile branch from b99aacd to 7e9def8 May 11, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 11, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@BenTheElder Had to push an additional change to move the comment out of the subshell, as bash3 doesn't like it.

@BenTheElder
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 11, 2019

@cblecker cblecker force-pushed the cblecker:codegen-mapfile branch from 7e9def8 to badac1b May 11, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 11, 2019

@BenTheElder
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit 44881eb into kubernetes:master May 12, 2019

20 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:codegen-mapfile branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.