Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish DeleteOptions parameters for deletecollection endpoints in OpenAPI spec #77843

Merged

Conversation

@roycaihw
Copy link
Member

commented May 14, 2019

Deletecollection endpoint handles DeleteOptions but we didn't register it in API installer, as a result DeleteOptions query & body parameters aren't reflected in our openapi spec.

Does this PR introduce a user-facing change?:

Publish DeleteOptions parameters for deletecollection endpoints in OpenAPI spec

/sig api-machinery

roycaihw added 2 commits May 13, 2019
@fedebongio

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

/assign @yliaog

@yliaog

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 17, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 18, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented May 18, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels May 18, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 18, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 76c214b into kubernetes:master May 18, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.