Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint failures of test/e2e/autoscaling #77913

Merged
merged 1 commit into from May 22, 2019
Merged

Fix golint failures of test/e2e/autoscaling #77913

merged 1 commit into from May 22, 2019

Conversation

s-ito-ts
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This fixes golint failures of the following file:

  • test/e2e/autoscaling/autoscaling_timer.go
  • test/e2e/autoscaling/cluster_autoscaler_scalability.go
  • test/e2e/autoscaling/cluster_size_autoscaling.go
  • test/e2e/autoscaling/custom_metrics_stackdriver_autoscaling.go
  • test/e2e/autoscaling/dns_autoscaling.go
  • test/e2e/autoscaling/framework.go
  • test/e2e/autoscaling/horizontal_pod_autoscaling.go

Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @s-ito-ts. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2019
neolit123
neolit123 reviewed May 16, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/priority backlog

/assign @oomichi

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2019
@oomichi
Copy link
Member

oomichi commented May 16, 2019

/retest

@s-ito-ts
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 20, 2019
@s-ito-ts
Copy link
Contributor Author

I rebased to resolve conflicts.
Could you review again?

@oomichi
Copy link
Member

oomichi commented May 21, 2019

/lgtm

Thanks for doing this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@oomichi
Copy link
Member

oomichi commented May 21, 2019

/approve

@s-ito-ts
Copy link
Contributor Author

/assign @fejta

fejta
fejta reviewed May 22, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, oomichi, s-ito-ts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit ec0f8b8 into kubernetes:master May 22, 2019
@s-ito-ts s-ito-ts mentioned this pull request Jun 5, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@fejta fejta fejta left review comments

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@neolit123 neolit123

@fejta fejta

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s-ito-ts @k8s-ci-robot @oomichi @neolit123 @fejta