Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of the kubeadm config upload command #77946

Merged
merged 1 commit into from May 17, 2019

Conversation

@Klaven
Copy link
Contributor

commented May 15, 2019

/kind cleanup

What this PR does / why we need it:
This PR deprecates the kubeadm config upload command and all of it's sub-commands as a replacement in the form of kubeadm init phase upload-config.

Which issue(s) this PR fixes:
refs #kubernetes/kubeadm#988

Special notes for your reviewer:
Note: I tested cobra and it did not appear that "deprecated" was inherited from the parent command necessitating deprecating the individual sub commands as well.

I thought the comments in the code where nice for anyone browsing the code... but could be labeled a distraction and wasted space. not sure your all preference on that.

Does this PR introduce a user-facing change?:

Deprecates the kubeadm config upload command as it's replacement is now graduated. Please see `kubeadm init phase upload-config`
Deprecation of the kubeamd config upload command
This also deprecated all the sub commands.
@Klaven

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/assign @rosti

@yagonobre
Copy link
Member

left a comment

Thanks!
/lgtm
/priority important-longterm

@neolit123
Copy link
Member

left a comment

/priority backlog

Short: "Create the in-cluster configuration file for the first time from using flags",
Deprecated: "please see kubeadm init phase upload-config",
Use: "from-flags",
Short: "Create the in-cluster configuration file for the first time from using flags",

This comment has been minimized.

Copy link
@neolit123

neolit123 May 15, 2019

Member

just wanted to note that potential consumers of this variant would need to migrate to file only.
also that we need to have this deprecated for 12 months as GA functionality.
cc @rosti

This comment has been minimized.

Copy link
@Klaven

Klaven May 15, 2019

Author Contributor

@neolit123 do you want me to put that in the above deprecation message?

This comment has been minimized.

Copy link
@neolit123

neolit123 May 15, 2019

Member

let's wait on rosti's comments.

This comment has been minimized.

Copy link
@rosti

rosti May 16, 2019

Member

This is actually the worst of them all. You don't get to see what's getting uploaded and users can easily mistake this to "patch" sort of command. Thus, they can inadvertently set some fields of their ClusterConfiguration to defaults and not even notice it.

@Klaven

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/test pull-kubernetes-e2e-gce

@rosti
rosti approved these changes May 16, 2019
Copy link
Member

left a comment

Thanks for this @Klaven !

I don't think, that there are that many users of kubeadm config upload from-flags, so I don't think, that we should put that much effort in it. At best, if users voice concerns for lack of instructions, we can document on the website how to download their current ClusterConfiguration (with kubectl) and then supply that to the init phase.

@Klaven just a tiny nit, can you change "Fixes" to "Refs" so that the original issue does not get closed upon merge? I want to reuse it to track there the fact that we want to remove the commands after about an year. Ping me when this is done to remove the hold.

/approve
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Klaven, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 628e0d8 into kubernetes:master May 17, 2019

20 checks passed

cla/linuxfoundation Klaven authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.