Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecation of the kubeadm config upload command #77946
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
I thought the comments in the code where nice for anyone browsing the code... but could be labeled a distraction and wasted space. not sure your all preference on that.
Does this PR introduce a user-facing change?:
rosti left a comment
Thanks for this @Klaven !
I don't think, that there are that many users of
@Klaven just a tiny nit, can you change "Fixes" to "Refs" so that the original issue does not get closed upon merge? I want to reuse it to track there the fact that we want to remove the commands after about an year. Ping me when this is done to remove the hold.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing