Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubectl log #78098

Merged
merged 1 commit into from Aug 29, 2019
Merged

Remove kubectl log #78098

merged 1 commit into from Aug 29, 2019

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 20, 2019

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
kubectl log was deprecated back in cb872e9 which is even before first release. I think we are now ready to finally remove that command.

Special notes for your reviewer:
/assign @liggitt

Does this PR introduce a user-facing change?:

Remove kubectl log, use kubectl logs instead

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 20, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2019
@soltysh
Copy link
Contributor Author

soltysh commented May 20, 2019

/sig cli
/priority important-longterm
/hold
until I we get a proper visibility on this one

@k8s-ci-robot k8s-ci-robot added area/kubectl do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
liggitt
liggitt reviewed May 20, 2019
View reviewed changes
test/e2e/kubectl/kubectl.go
@@ -1233,7 +1233,7 @@ metadata:
Testname: Kubectl, logs
Description: When a Pod is running then it MUST generate logs.
Starting a Pod should have a log line indicating the server is running and ready to accept connections. Also log command options MUST work as expected and described below.
‘kubectl log -tail=1’ should generate a output of one line, the last line in the log.
‘kubectl logs -tail=1’ should generate a output of one line, the last line in the log.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still running framework.RunKubectlOrDie("log"... below.

@kubernetes/cncf-conformance-wg what's the protocol for removing a deprecated thing used by a conformance test? change the test in 1.15 and remove the thing in 1.16?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we can just change the test now and remove the thing. Conformance tests evaluate whether the subject cluster conforms. If it can't handle the new command, it's not really conforming. If it can't handle the old one, and it is within the deprecation period (the CLI deprecation policy is the longer of 12 months or 2 releases (https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli)), then it wouldn't be considered conforming either. But 1) it's been more than 3 years so we are safely beyond that 12 months; and 2) this test isn't about backwards compat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the command is within rights to be removed.

I just wasn't sure if 1.14 conformance tests needed to be able to run against 1.15 clusters.

@liggitt
Copy link
Member

liggitt commented May 22, 2019

@soltysh sounds like we can drop this, just need to fix the invocations from the e2e tests

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Jun 3, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Jun 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2019
@johnbelamaric
Copy link
Member

ping...this is approved but now needs rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Aug 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi
Copy link
Contributor

damemi commented Aug 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@sallyom
Copy link
Contributor

sallyom commented Aug 29, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@sallyom: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 3cf2d32 into kubernetes:master Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@soltysh soltysh deleted the remove_logs branch August 30, 2019 09:44
This was referenced Aug 31, 2019
Closed
Merged
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#78098 from soltysh/remove_logs
bd0a1a2 
Remove kubectl log

Kubernetes-commit: 3cf2d32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@liggitt liggitt

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@soltysh @liggitt @johnbelamaric @k8s-ci-robot @damemi @sallyom @fejta-bot