Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubectl log #78098

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@soltysh
Copy link
Contributor

commented May 20, 2019

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
kubectl log was deprecated back in cb872e9 which is even before first release. I think we are now ready to finally remove that command.

Special notes for your reviewer:
/assign @liggitt

Does this PR introduce a user-facing change?:

Remove kubectl log, use kubectl logs instead
@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

/sig cli
/priority important-longterm
/hold
until I we get a proper visibility on this one

@@ -1233,7 +1233,7 @@ metadata:
Testname: Kubectl, logs
Description: When a Pod is running then it MUST generate logs.
Starting a Pod should have a log line indicating the server is running and ready to accept connections. Also log command options MUST work as expected and described below.
‘kubectl log -tail=1’ should generate a output of one line, the last line in the log.
‘kubectl logs -tail=1’ should generate a output of one line, the last line in the log.

This comment has been minimized.

Copy link
@liggitt

liggitt May 20, 2019

Member

this is still running framework.RunKubectlOrDie("log"... below.

@kubernetes/cncf-conformance-wg what's the protocol for removing a deprecated thing used by a conformance test? change the test in 1.15 and remove the thing in 1.16?

This comment has been minimized.

Copy link
@johnbelamaric

johnbelamaric May 22, 2019

Contributor

No, we can just change the test now and remove the thing. Conformance tests evaluate whether the subject cluster conforms. If it can't handle the new command, it's not really conforming. If it can't handle the old one, and it is within the deprecation period (the CLI deprecation policy is the longer of 12 months or 2 releases (https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli)), then it wouldn't be considered conforming either. But 1) it's been more than 3 years so we are safely beyond that 12 months; and 2) this test isn't about backwards compat.

This comment has been minimized.

Copy link
@liggitt

liggitt May 22, 2019

Member

I agree the command is within rights to be removed.

I just wasn't sure if 1.14 conformance tests needed to be able to run against 1.15 clusters.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@soltysh sounds like we can drop this, just need to fix the invocations from the e2e tests

@soltysh soltysh force-pushed the soltysh:remove_logs branch from 13d5353 to 9a85456 May 28, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels May 28, 2019
@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 3, 2019
@johnbelamaric

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

ping...this is approved but now needs rebase

@soltysh soltysh force-pushed the soltysh:remove_logs branch from 9a85456 to 6939e77 Aug 29, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 29, 2019
@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/lgtm

@sallyom

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@sallyom: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 29, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 3cf2d32 into kubernetes:master Aug 29, 2019
24 checks passed
24 checks passed
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@soltysh soltysh deleted the soltysh:remove_logs branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.