Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow trailing dot for service.spec.externalName #78385
What type of PR is this?
What this PR does / why we need it:
This PR relaxes the validation of service.spec.externalName to allow a trailing dot. (See #78384 for details).
Which issue(s) this PR fixes:
Special notes for your reviewer:
A similar related case, which also relaxed the trailing-dot validation: #74686
Does this PR introduce a user-facing change?:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Hi @thz. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@thz: Cannot trigger testing until a trusted user reviews the PR and leaves an