Skip GCE PD in-tree plugin tests if fstype is xfs and node distro is not ubuntu or custom

[davidz627]

XFS Is not supported in other node OS distros. These tests are failing in multiple places

/kind failing-test
/sig storage
/priority important-soon

/assign @msau42 @mkimuram

NONE

[gnufied]

/lgtm

[davidz627]

/assign @saad-ali
/retest

[saad-ali]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/storage/OWNERS [saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidz627]

/retest

[mkimuram]

@davidz627

If this PR fixes the issue, below comments aren't urgent, but it would be worth consider them later.

I thought that this was skipped by this code, as a result of the discussion in (#70823, #70823 (comment))
Isn't it enough? (Then, we might consider fixing these codes work correctly or removing them.)

Also, I guess that it would be better to add comments on

• which combinations of providers and NodeOSDistros are tested against gcePdDriver,
• which filesystem should be tested in which condition.

It seems that the combinations become more complex as windows node case is added, so it is difficult to see what is the right behavior just from the code.

[davidz627]

/hold

[davidz627]

@mkimuram thanks for bringing those other skips to my attention. I think it's better to add these FS skips there.

Looks like right now xfs is only skipped on gci, when in reality it should be skipped on everything except ubuntu.

[davidz627]

/assign @mkimuram
PTAL at new change

[mkimuram]

@davidz627

Could you let me know which particular NodeOSDistro actually fails?

I think that we should add the particular NodeOSDistro to the black list to skip xfs tests, instead of making it a white list for just "ubuntu" and "custom". (Xfs must be a common filesystem that can be supported in many linux distributions, so this change will affect tests for combinations of other drivers and other distributions. )

As I commented on the previous discussion, this code is shared in all storage testsuites across all drivers and will be tested by any NodeOSDistros, so we won't be able to whitelist all NodeOSDistros, here. (If it is only for gcepd driver code, like previous commit, it makes sense to just blacklisting some NodeOSDistros, because we can be sure that the driver will only be tested with some certain NodeOSDistros.)

[davidz627]

@mkimuram I see, that's a fair point. I changed back it from a whitelist to a blacklist.

[davidz627]

/retest

[mkimuram]

@davidz627

Thank you for handling this.
The code looks good to me if the content of blacklist itself is correct. (And it must be correct, if all tests pass.)

[davidz627]

/retest

[msau42]

/lgtm

[davidz627]

/hold cancel

[davidz627]

Should probably fix: #71436

[davidz627]

@claurence this is a test fix only and might help improve signal on certain OS distributions (windows, COS, since this will remove irrelevant tests)
Just pinging in case you want to get this merged

[tpepper]

Should probably fix: #71436

It may not have...OR it needs back ported to the prior branches.