Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add accessLogs support for aws nlb #78497

Merged
merged 1 commit into from Jun 1, 2019
Merged

add accessLogs support for aws nlb #78497

merged 1 commit into from Jun 1, 2019

Conversation

M00nF1sh
Copy link
Contributor

@M00nF1sh M00nF1sh commented May 29, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Support to enable accessLogs for NLB

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Test done:

  1. Enable / Disable cross-zone-loadbalancing continue works.
  2. Enable NLB accessLogs with bucket only works.
  3. Enable NLB accessLogs with bucket/prefix works.
  4. Switch NLB accessLogs from bucket only to bucket/prefix works.
  5. Disable NLB accessLogs works.

Does this PR introduce a user-facing change?:

Supports configure accessLogs for AWS NLB

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2019
@M00nF1sh
Copy link
Contributor Author

/milestone v1.15

@k8s-ci-robot
Copy link
Contributor

@M00nF1sh: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@M00nF1sh
Copy link
Contributor Author

/test pull-kubernetes-dependencies

micahhausler
micahhausler approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

staging/src/k8s.io/legacy-cloud-providers/aws/aws_loadbalancer.go
@@ -45,6 +45,11 @@ const (
// SSLNegotiationPolicyNameFormat is a format string used for the SSL
// negotiation policy tag name
SSLNegotiationPolicyNameFormat = "k8s-SSLNegotiationPolicy-%s"

lbAttrLoadBalancingCrossZoneEnabled = "load_balancing.cross_zone.enabled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you add a doc comment?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@alejandrox1
Copy link
Contributor

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit a7a2897 into kubernetes:master Jun 1, 2019
@M00nF1sh M00nF1sh mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahhausler micahhausler micahhausler approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@micahhausler micahhausler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@M00nF1sh @k8s-ci-robot @alejandrox1 @micahhausler