Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessLogs support for aws nlb #78497

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@M00nF1sh
Copy link
Contributor

commented May 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Support to enable accessLogs for NLB

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Test done:

  1. Enable / Disable cross-zone-loadbalancing continue works.
  2. Enable NLB accessLogs with bucket only works.
  3. Enable NLB accessLogs with bucket/prefix works.
  4. Switch NLB accessLogs from bucket only to bucket/prefix works.
  5. Disable NLB accessLogs works.

Does this PR introduce a user-facing change?:

Supports configure accessLogs for AWS NLB
@M00nF1sh

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/milestone v1.15

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@M00nF1sh: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@M00nF1sh

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/test pull-kubernetes-dependencies

@M00nF1sh M00nF1sh force-pushed the M00nF1sh:access_nlb branch from 04d950b to 33e6465 May 29, 2019

@micahhausler
Copy link
Member

left a comment

/lgtm
/approve

@@ -45,6 +45,11 @@ const (
// SSLNegotiationPolicyNameFormat is a format string used for the SSL
// negotiation policy tag name
SSLNegotiationPolicyNameFormat = "k8s-SSLNegotiationPolicy-%s"

lbAttrLoadBalancingCrossZoneEnabled = "load_balancing.cross_zone.enabled"

This comment has been minimized.

Copy link
@micahhausler

micahhausler May 30, 2019

Member

nit: Can you add a doc comment?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alejandrox1

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 30, 2019

@k8s-ci-robot k8s-ci-robot merged commit a7a2897 into kubernetes:master Jun 1, 2019

20 of 21 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation M00nF1sh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.