Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test/e2e use to v1 APIs #78614

Merged
merged 1 commit into from Jun 14, 2019
Merged

Move test/e2e use to v1 APIs #78614

merged 1 commit into from Jun 14, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 1, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Many of the APIs we use for e2e setup have graduated to v1. Switch to the v1 APIs.

Which issue(s) this PR fixes:
xref #78613

Does this PR introduce a user-facing change?:

NONE

/cc @oomichi
/area conformance

@k8s-ci-robot k8s-ci-robot requested a review from oomichi June 1, 2019 01:59
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 1, 2019
@liggitt liggitt added this to the v1.16 milestone Jun 1, 2019
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2019
@liggitt liggitt mentioned this pull request Jun 1, 2019
Closed
@liggitt
Copy link
Member Author

liggitt commented Jun 1, 2019

/retest

2 similar comments
@liggitt
Copy link
Member Author

liggitt commented Jun 1, 2019

/retest

@oomichi
Copy link
Member

oomichi commented Jun 2, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 3, 2019

/retest

oomichi
oomichi reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for doing this.

cluster/addons/metrics-server/metrics-apiservice.yaml
@@ -1,4 +1,4 @@
apiVersion: apiregistration.k8s.io/v1beta1
apiVersion: apiregistration.k8s.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM because of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#apiservice-v1-apiregistration-k8s-io

cluster/addons/kube-proxy/kube-proxy-rbac.yaml
@@ -7,7 +7,7 @@ metadata:
addonmanager.kubernetes.io/mode: Reconcile
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM because of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#clusterrole-v1-rbac-authorization-k8s-io

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2019
@oomichi oomichi mentioned this pull request Jun 3, 2019
Merged
@oomichi
Copy link
Member

oomichi commented Jun 3, 2019

/retest

spiffxp
spiffxp suggested changes Jun 3, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here can we bring test/e2e into consistency as far as api imports? Noted one in a review comment, there other is:

test/e2e/auth/certificates.go
25:	"k8s.io/api/certificates/v1beta1"

There are lots of other imports of "k8s.io/api/core/v1" instead of the v1 "k8s.io/api/core/v1" style you have going here, but those seem too equivalent to bother noting here.

(found via ag '^[ \t]*\"[.a-z0-9/]*v1[a-z0-9]*\"' test/e2e)

test/e2e/apimachinery/webhook.go
@@ -25,7 +25,7 @@ import (
"k8s.io/api/admissionregistration/v1beta1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're here, admissionregistrationv1beta1?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2019
@liggitt
Copy link
Member Author

liggitt commented Jun 3, 2019

While we're here can we bring test/e2e into consistency as far as api imports?

I'd prefer a no-op import rename be separate if you don't mind

@spiffxp
Copy link
Member

spiffxp commented Jun 3, 2019 •
edited

/priority important-soon

I'd prefer a no-op import rename be separate if you don't mind

fair enough

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 3, 2019
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 3, 2019
@spiffxp spiffxp added this to In Review in conformance-definition Jun 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7abf283 into kubernetes:master Jun 14, 2019
conformance-definition automation moved this from In Review to Done Jun 14, 2019
@spiffxp spiffxp mentioned this pull request Jun 19, 2019
Merged
@liggitt liggitt deleted the remove-beta-e2e-use branch June 22, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@spiffxp spiffxp spiffxp approved these changes

Assignees

@spiffxp spiffxp

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @oomichi @spiffxp @fedebongio