Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: complete default-under-metadata validation and storage pruning #78829

Conversation

@sttts
Copy link
Contributor

commented Jun 9, 2019

Implement the validation part of kubernetes/enhancements#1166. Storage default pruning will be a follow-up. Both the validation and storage part is included.

Possible follow-ups (not in this PR):

  • make error paths in under-metadata default values absolute
Verify that CRD default values in OpenAPI specs are pruned, with the exceptions of values under `metadata`.

@k8s-ci-robot k8s-ci-robot requested review from deads2k and pwittrock Jun 9, 2019

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 90b489c to 1e4f2f9 Jun 10, 2019

@sttts sttts added this to the v1.16 milestone Jun 10, 2019

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 1e4f2f9 to 67d25f5 Jun 10, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Jun 10, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

/assign @roycaihw
/cc @jennybuckley

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt Aug 7, 2019

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 67d25f5 to 4f8261b Aug 17, 2019

@sttts sttts changed the title WIP: apiextensions: complete default-under-metadata validation apiextensions: complete default-under-metadata validation Aug 17, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

(also fix the golint verify errors :-/)

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 5b49db8 to 1bfd7e9 Aug 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

/approve

squash review commits, fixup lint, then lgtm

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 1bfd7e9 to 55e2255 Aug 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 23, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-metadata-defaulting branch from 55e2255 to 4fd200c Aug 23, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 23, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Again no bazel test logs.

/retest

@k8s-ci-robot k8s-ci-robot merged commit f9afe46 into kubernetes:master Aug 24, 2019

23 of 24 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.