Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files: stringlist -> list (similar to set) #789

Merged
merged 1 commit into from
Aug 7, 2014

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 5, 2014

Part of a collection of nits I am finding as I catch up on PRs.

@lavalamp
Copy link
Member

lavalamp commented Aug 5, 2014

Not sure what use this type is, anyway. Can we get rid of it completely?

@thockin
Copy link
Member Author

thockin commented Aug 7, 2014

It's used for a few flags, like etcd_servers.

On Mon, Aug 4, 2014 at 11:38 PM, Daniel Smith notifications@github.com
wrote:

Not sure what use this type is, anyway. Can we get rid of it completely?

Reply to this email directly or view it on GitHub
#789 (comment)
.

@brendandburns
Copy link
Contributor

LGTM. I think @proppy added it, mostly for use in flags.

brendandburns added a commit that referenced this pull request Aug 7, 2014
Rename files: stringlist -> list (similar to set)
@brendandburns brendandburns merged commit b43e386 into kubernetes:master Aug 7, 2014
vishh pushed a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants